Skip to content

404 error on the left side of the /pulls page (external issue tracker) #7140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 7 tasks
mindfl opened this issue Jun 5, 2019 · 7 comments
Closed
2 of 7 tasks
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@mindfl
Copy link

mindfl commented Jun 5, 2019

Description

404 error on the left side of the /pulls page if repo is configured with no issue tracker, or with an external issue tracker.

Similar issues

But the problem looks like still exists, or may be it's just a similar with closed issues.

Steps to reproduce

  1. Create a repository that is configured with no issue tracker, or with an external issue tracker
  2. Create a Pull Request
  3. Go to the https://try.gitea.io/pulls page
  4. Press on a link on a left side
  5. 404, but the filtered page like as repo with gitea internal issue tracker enabled is expected

Screenshots

Steps to reproduce

src_20190605-234302

Error

src_20190606-000424

@lunny lunny added the type/bug label Jun 6, 2019
@mindfl mindfl changed the title 404 error on the left side of /pulls page (external issue tracker) 404 error on the left side of the /pulls page (external issue tracker) Jun 6, 2019
@stale
Copy link

stale bot commented Aug 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 5, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 5, 2019
@stale stale bot removed the issue/stale label Aug 5, 2019
@Toxik1983
Copy link

This issue is still present in 1.10.2. Our team only uses external trackers, so these links are always broken. Please implement a fix.

@lunny
Copy link
Member

lunny commented Jan 17, 2020

I think this is because you ever used internal issue tracker and then converted to external issue tracker. But this is a real bug that we should don't display those repositories which has external issue tracker enabled.

@ryan-shaw ryan-shaw mentioned this issue Feb 4, 2020
7 tasks
@Toxik1983
Copy link

I think this is because you ever used internal issue tracker and then converted to external issue tracker.

I believe you are right. A lot of other projects work fine with a combination of PRs and external trackers. Isn't there some way to get rid of the old issue tracker data?

But this is a real bug that we should don't display those repositories which has external issue tracker enabled.

I don't think that is correct. The /pulls page should just be a list of PRs, at least in our case. But there is an internal dependency on issues, because the links to the PRs of other projects with an external tracker enabled point to [organization]/[project]/issues/[id] but actually just redirect to [organization]/[project]/pulls/[id].

@guillep2k
Copy link
Member

This may have been fixed in #10092

@Toxik1983
Copy link

This may have been fixed in #10092

Thanks for mentioning this, I'll keep an eye on the release logs and update when it's available.

@Toxik1983
Copy link

This may have been fixed in #10092

Thanks for mentioning this, I'll keep an eye on the release logs and update when it's available.

Somehow I missed this in the 1.11.0 release log. I updated this morning and can confirm that this has been fixed.

@lunny lunny closed this as completed Feb 18, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Development

No branches or pull requests

4 participants