Skip to content

mentioning users dropdown during message composition #7218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 7 tasks
bryanpedini opened this issue Jun 16, 2019 · 16 comments
Closed
2 of 7 tasks

mentioning users dropdown during message composition #7218

bryanpedini opened this issue Jun 16, 2019 · 16 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@bryanpedini
Copy link

  • Gitea version (or commit ref): try.gitea.io (1.9.0+dev-353-gcf2221e3a)
  • Git version: IDK
  • Operating system: IDK
  • Database (use [x]): IDK
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (URL not relevant)
    • No
    • Not relevant
  • Log gist:

Description

Try to mention somebody in this issue, try to mention me, a dropdown that helps you autocomplete appears;
Try to do the same thing on a Gitea hosted server, let's hope you remember the exact username...

@bryanpedini
Copy link
Author

This is actually more a "feature request" than a bug, but whatever...

PS: yes, I find it funny and entertaining into discovering bugs of open source programs whenever I have spare time to;
'cause who knows, maybe I'm helping getting that software better..

@lunny
Copy link
Member

lunny commented Jun 16, 2019

Sorry, I don't know what did you mean.

@bryanpedini
Copy link
Author

bryanpedini commented Jun 16, 2019

Sorry, I don't know what did you mean.

The helpful dropdown that autocompletes mentions

It's present here on GitHub:
dropdown

It's present on GitLab:
dropdown

But not on Gitea, forcing people to remember exact username of the one you want to mention.

@lunny
Copy link
Member

lunny commented Jun 16, 2019

I don't know which version you are using.

Jietu20190616-220709

@bryanpedini
Copy link
Author

Oh, sorry... 1.7.5
Is that "feature" already implemented on newers? I created the issue just 'cause I didn't see any opened / closed issue on this topic so thought even on new releases it wasn't present...

@lunny
Copy link
Member

lunny commented Jun 16, 2019

@bryanpedini yes, it has been implemented. You can always try the new feature on https://try.gitea.io

@bryanpedini
Copy link
Author

Is it enabled on current latest 1.8.2?
If it is, could you please take a look on #7216 to check if an update/upgrade could help, 'cause I'm currently waiting to upgrade my instace for that issue...

@bryanpedini
Copy link
Author

bryanpedini commented Jun 16, 2019

Also...

You can always try the new feature on https://try.gitea.io

I did that here https://try.gitea.io/niaoked/test/issues/1 'cause was the first repo to come up under "explore".. but did dropdown didn't come up there on gitea try instance...

@lunny
Copy link
Member

lunny commented Jun 16, 2019

You cannot mention anyone you want currently, just the people your team members.

@bryanpedini
Copy link
Author

bryanpedini commented Jun 16, 2019

Aaaah, I see... thanks for the clarification!
Could it then be a next feature like here in GitHub then? (maybe?)

@lunny
Copy link
Member

lunny commented Jun 16, 2019

@bryanpedini I think we can, but we need a better performance method to do that. Currently just find the people via database.

@bryanpedini
Copy link
Author

Maybe searching people in the database but just those people that have contributed at least once on the repository you are currently mentioning users in PRs or issues;
Or people that you currently have mentioned in the past;
Or that you have added at least once in any of your repositories;

Or any combination of those (caching would be nice too like in a temporary table or a view...)
(if it is possible, IDK..)

@lunny
Copy link
Member

lunny commented Jun 16, 2019

Yeah. It's possible. Need some PRs from some people. :)

@bryanpedini
Copy link
Author

Hahaha... yeah...

Hook me up if you need any help / idea (not practic with Golang but could figure out the logic, IDK)...
(maybe assign 1.x.x and kind/feature?)

@stale
Copy link

stale bot commented Aug 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 15, 2019
@lunny lunny added type/enhancement An improvement of existing functionality issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels Aug 15, 2019
@stale stale bot removed the issue/stale label Aug 15, 2019
@worthy7
Copy link

worthy7 commented Sep 5, 2019

This can be closed btw, the specified functionality is already there. (It's not perfect, but that's another issue)

@lunny lunny closed this as completed Sep 5, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants