Skip to content

Link notifications to the comment anchor #8362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bobemoe opened this issue Oct 3, 2019 · 3 comments
Closed

Link notifications to the comment anchor #8362

bobemoe opened this issue Oct 3, 2019 · 3 comments
Labels
issue/stale type/enhancement An improvement of existing functionality

Comments

@bobemoe
Copy link
Contributor

bobemoe commented Oct 3, 2019

The notifications are great, giving a quick link to the issues that has been updated, but when an issue has lots of comments I find myself spending a lot of time scrolling down to get to the latest comment. Would it be possible to link to the latest comment anchor?
(e.g .../issues/184#issuecomment-7758 rather than just .../issues/184)

This is already done in the email notification (#1669) its easy there because each update has its own email, which can contain a specific link.

I guess the problem with the notification in the web fronted is that multiple updates for a single issue are all rolled into one notification. What happens if there is a combination of comments and non-comment updates? Do we:

  • Link to the top of the issue (as we do now)
  • Have one notification per update? (bit spammy, do we mark them all read when one is read?)
  • Link the the first new comment?
  • Link to the last new comment?
  • Provide some buttons so the user can choose?
  • Provide a summary showing the types of updates?
  • Highlight all the updated elements when loading the issue page?

I see some discussions going on about the notification system over here: #145 but had hoped this could be a quick fix, however upon consideration of the above list it looks like it needs some more thought... hmm... thoughts?

@guillep2k
Copy link
Member

guillep2k commented Oct 4, 2019

I think the easiest and most sensible option would be to link to the first new comment.

@lunny lunny added the type/enhancement An improvement of existing functionality label Oct 7, 2019
@stale
Copy link

stale bot commented Dec 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Dec 6, 2019
@stale
Copy link

stale bot commented Dec 20, 2019

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Dec 20, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/stale type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants