Skip to content

I'm still receiving email notifications for issue comments while not watching repo and not being subscribed to issue #8879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
strk opened this issue Nov 8, 2019 · 11 comments · Fixed by #10475
Labels
Milestone

Comments

@strk
Copy link
Member

strk commented Nov 8, 2019

I saw this happening on gitea.com, but cant remember the exact issue it was occurring for.
@lunny might recall

@strk
Copy link
Member Author

strk commented Nov 8, 2019

Found the reference: https://gitea.com/gitea/go-sdk/pulls/185#issuecomment-79877
This is Gitea Version: 1.11.0+dev-110-gc4bc5abda

@lunny lunny added the type/bug label Nov 8, 2019
@stale
Copy link

stale bot commented Jan 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 7, 2020
@lunny
Copy link
Member

lunny commented Jan 17, 2020

Is this still a problem?

@stale stale bot removed the issue/stale label Jan 17, 2020
@strk
Copy link
Member Author

strk commented Jan 20, 2020

@6543 did you complete your work on this ?

@6543
Copy link
Member

6543 commented Jan 20, 2020

#9535

@6543
Copy link
Member

6543 commented Jan 20, 2020

Jes I'll finish but think in 2/3 weeks I'll start coding again ...

@6543
Copy link
Member

6543 commented Jan 20, 2020

@strk feel free to pick this up if you need it soon

@guillep2k
Copy link
Member

@6543 did you complete your work on this ?

@strk this particular issue should be fixed for you. The PR @6543 is working on is an enhancement that will let you unsubscribe from a particular issue without unwatching the repository (i.e. the user will still get notifications for other issues in that repository). Since this issue was about you receiving notifications despite not watching the repository, that PR is unrelated.

@strk
Copy link
Member Author

strk commented Jan 21, 2020

I was not watching but I was a partecipant due to some interaction. I understand explicit unsubscribe is the only way to fix this. I don't need this soon, but I'd rather only close this ticket when the problem is really fixed (problem of receiving notifications while not watching repo and not being subscribed)

@6543
Copy link
Member

6543 commented Feb 26, 2020

I'll finaly take this issue :) - will send a pull when #10401 is merged, then I have to look at
services/mailer/mail_issue.go anyway...

@6543
Copy link
Member

6543 commented Feb 26, 2020

@strk bugfix: #10475

@lafriks lafriks added this to the 1.11.2 milestone Feb 27, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants