Skip to content

Can't tab away from selectable dropdown menus #8919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 7 tasks
Jookia opened this issue Nov 11, 2019 · 4 comments
Closed
1 of 7 tasks

Can't tab away from selectable dropdown menus #8919

Jookia opened this issue Nov 11, 2019 · 4 comments
Labels
Milestone

Comments

@Jookia
Copy link
Contributor

Jookia commented Nov 11, 2019

  • Gitea version (or commit ref): master
  • Git version: master
  • Operating system: Debian
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

After merging #8638 selectable dropdown menus now seem to grab focus. I did some bisection on my original branch and found it was introduced just by adding semantic.dropdown.js unchanged from upstream.

@lunny lunny added the type/bug label Nov 11, 2019
@lunny lunny added this to the 1.11.0 milestone Nov 11, 2019
@Jookia
Copy link
Contributor Author

Jookia commented Nov 11, 2019

I found wrong. The issue is that my fix for clicking not working with the keyboard brought about another problem: Whenever a select box is tabbed away from, the selection is confirmed. This is done by clicking on the element. Which refocuses it like you would expect when clicking normally.

@ppst0
Copy link

ppst0 commented Nov 11, 2019

The same problem. Choose create new repo, selecting License and then can't select another field even with mouse click.

Use latest docker image from docker hub (133c950411eb)
git with screen cap

@Jookia
Copy link
Contributor Author

Jookia commented Nov 11, 2019

Ok, #8921 is up as a hotfix. It reverts my change that showed this broken behaviour but it still needs to be fixed properly

@guillep2k
Copy link
Member

I think this issue can be closed. If anything is missing from ARIA support because of #8921, that should be a different issue.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants