Rename /forget_password url to /forgot_password

[strk]

No description provided.

[lunny]

just remove the wrong line is ok

[lunny]

duplicated.

[strk]

Fixed (I don't think this is kind/docs, btw)

[strk]

Hold on a second, there are duplications in each and every translation :/
I'm not sure what happened. Maybe someone added a question mark after I initially made the PR, and the rebase didn't recognize it. Fixing it

[lunny]

@strk every file has a duplicated line.

[strk]

ok, figured. The forgot_password key is currently being used as the title for the Forgot Password page,
while the forget_password key is used for the link text.

So the new commit (replacing the others) changes forgot_password to forgot_password_title and then changes forget_password to forgot_password. Should be good now.

[bkcsoft]

This needs a big disclaimer in the changelog 😛

[strk]

@bkcsoft you seemed less concerned in #862 (comment) ? Or is this specifically for the translation keys ?

[bkcsoft]

@strk Well, people might depend on the link, so we need a changelog entry, as for the API it doesn't care 🙂

[strk]

Did anyone setup that changelog/ support mechanism ? I'd be glad to provide a changelog within this PR if that's the case (and if so: where is it documented?)

[lunny]

Why we need two similar strings?

[strk]

One is the link text (usually ends with a question mark: "Forgot password?") the other is the title of the HTML page where you click the confirmation button (thus the "_title" suffix in the new key).

[lunny]

LGTM except @bkcsoft 's opinion

[strk]

@bkcsoft I'm ok with the changelog entry, should I add it to the current CHANGELOG, drafting the new line (and fixing conflicts as we go) ? Or we could use a [changelog:compatibility] tag in commit logs to extract later ? Or what else do you want me to do for this to be accepted ?

[bkcsoft]

Put it in the Changelog under "Unreleased" (make a section at the top) and someone will take take of it 😉

[thibaultmeyer]

LGTM

[bkcsoft]

Just put a changelog somewhere (just so it can't be merged before that 😂 )

[strk]

Are you @go-gitea/maintainers ok if we start dropping changelogs in files under a pending-changelogs/ directory, to be checked and cleaned up before final release ?

Please vote with thumbs up/down on this comment :)

[bkcsoft]

@strk changelog/unreleased as per #1298 😉

[strk]

@bkcsoft section added, and squash rebased against master