Skip to content

Fix delete user failed on sqlite #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 1 commit into from
Mar 20, 2017
Merged

Fix delete user failed on sqlite #1321

lunny merged 1 commit into from
Mar 20, 2017

Conversation

@lunny
Copy link
Member

@lunny lunny commented Mar 19, 2017

fix #1281, @zileyuan and @crocket please confirm this PR will resolve your problem.

@lunny lunny added this to the 1.2.0 milestone Mar 19, 2017
@crocket
Copy link

crocket commented Mar 19, 2017

How do I test this?
The instructions on https://docs.gitea.io/en-us/install-from-source are not applicable to this.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 19, 2017
@strk strk mentioned this pull request Mar 20, 2017
Closed
1 task
@strk
Copy link
Member

strk commented Mar 20, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 20, 2017
@lunny
Copy link
Member Author

lunny commented Mar 20, 2017

fix #1145

@appleboy
Copy link
Member

appleboy commented Mar 20, 2017

LGTM

@appleboy
Copy link
Member

appleboy commented Mar 20, 2017

let L-G-T-M work

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 20, 2017
@lunny lunny merged commit 888dee3 into go-gitea:master Mar 20, 2017
@lunny lunny deleted the lunny/fix_delete_user branch March 20, 2017 14:14
@gravemalte gravemalte mentioned this pull request May 16, 2017
Closed
7 tasks
lunny added a commit to lunny/gitea that referenced this pull request May 17, 2017
@lunny
fix delete user failed on sqlite (go-gitea#1321)
f74fbdd
@lunny lunny mentioned this pull request May 17, 2017
Merged
@lunny lunny added the backport/done All backports for this PR have been created label May 17, 2017
bkcsoft pushed a commit that referenced this pull request May 17, 2017
@lunny @bkcsoft
fix delete user failed on sqlite (#1321)
fa059de
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

sqlite db delete user error

5 participants

@lunny @crocket @strk @appleboy @tboerger