Fix FCGI (over TCP) support #1368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/feature
Member
|
Could you please also send an integration to https://docs.gitea.io/en-us/config-cheat-sheet/ ? (as I don't find any FCGI mention in there...) |
tboerger
added
the
lgtm/need 2
Member
|
LGTM now that I red go-gitea/docs#107 (please merge that one too!) |
tboerger
added
lgtm/need 1
appleboy
approved these changes
Mar 23, 2017
Member
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although basic FCGI support is present since 2014 (gogs/gogs#601), it's not usable.
This commit adds support for serving via FCGI protocol over tcp socket.
The socket address:port is derived from HTTP_ADDR and HTTP_PORT configuration settings.
Tested on OpenBSD-current with OpenBSD's httpd.