Skip to content

Fix markdown rendering #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
appleboy merged 1 commit into from
Apr 24, 2017
Merged

Fix markdown rendering #1530

appleboy merged 1 commit into from
Apr 24, 2017

Conversation

@Morlinest
Copy link
Member

@Morlinest Morlinest commented Apr 21, 2017

Fix rendering bug caused by PR #186.

Simplify nested "if".

@lunny lunny added this to the 1.2.0 milestone Apr 21, 2017
@lunny lunny added the type/bug label Apr 21, 2017
@strk
Copy link
Member

strk commented Apr 21, 2017

Maybe you should wait for #1527 before touching this file. \cc @lunny

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 21, 2017
@lunny
Copy link
Member

lunny commented Apr 21, 2017 •
edited
Loading

Could you give an example of this bug on https://try.gitea.io?

@lunny
Copy link
Member

lunny commented Apr 21, 2017

@strk I don't think so.

@Morlinest
Copy link
Member Author

Morlinest commented Apr 21, 2017

Should fix #1273, #1265.

@Morlinest
Copy link
Member Author

Morlinest commented Apr 21, 2017 •
edited
Loading

@lunny https://try.gitea.io/morli/test
Before:
image

After:
image

@andrew-boyarshin
Copy link
Contributor

andrew-boyarshin commented Apr 22, 2017

Yeah, looks like an issue I've missed. Thanks, @Morlinest!
It would also be great to have tests written for this case.

@lunny
Copy link
Member

lunny commented Apr 24, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 24, 2017
@ethantkoenig
Copy link
Member

ethantkoenig commented Apr 24, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2017
@appleboy
Copy link
Member

appleboy commented Apr 24, 2017

LGTM

@appleboy appleboy merged commit fcc7cda into go-gitea:master Apr 24, 2017
@Morlinest Morlinest deleted the fix-markdown-render-list branch April 24, 2017 09:12
lunny pushed a commit to lunny/gitea that referenced this pull request Jun 23, 2017
@Morlinest @lunny
Fix markdown rendering (go-gitea#1530)
58dcbaf
@lunny lunny mentioned this pull request Jun 23, 2017
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Jun 23, 2017
andreynering added a commit that referenced this pull request Jun 23, 2017
@andreynering
Merge pull request #2043 from lunny/lunny/fix_markdown_render_list
39cb1ac 
Fix markdown rendering (#1530)
@ethantkoenig ethantkoenig mentioned this pull request Jul 7, 2017
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@appleboy appleboy appleboy approved these changes

@ethantkoenig ethantkoenig ethantkoenig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

7 participants

@Morlinest @strk @lunny @andrew-boyarshin @ethantkoenig @appleboy @tboerger