Skip to content

Conversation

@bkcsoft
Copy link
Member

@bkcsoft bkcsoft commented Apr 30, 2017

Backport of #1461

- Add code-injection checks
@bkcsoft bkcsoft requested review from appleboy and lunny April 30, 2017 06:26
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 30, 2017
// Multiple calls to this function will only create one instance of Sanitizer during
// entire application lifecycle.
func NewSanitizer() {
log.Trace("Markdown: sanitizer initialization requested")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember this will break SSH

// Custom URL-Schemes
sanitizer.policy.AllowURLSchemes(setting.Markdown.CustomURLSchemes...)

log.Trace("Markdown: sanitizer initialized")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this line.

@lunny lunny added this to the 1.1.1 milestone Apr 30, 2017
@lunny lunny added the type/bug label Apr 30, 2017
@lunny
Copy link
Member

lunny commented Apr 30, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 30, 2017
@lunny lunny merged commit 473df53 into release/v1.1 Apr 30, 2017
@bkcsoft bkcsoft deleted the bp-1-1/fix-sanitation branch June 15, 2017 02:41
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants