Skip to content

fixes wrong after field in webhook payload #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bkcsoft merged 1 commit into from
May 19, 2017
Merged

fixes wrong after field in webhook payload #1746

bkcsoft merged 1 commit into from
May 19, 2017

Conversation

@favadi
Copy link
Contributor

@favadi favadi commented May 18, 2017

Fix #1350

@lunny lunny added this to the 1.2.0 milestone May 18, 2017
@lunny lunny added the type/bug label May 18, 2017
@ethantkoenig
Copy link
Member

ethantkoenig commented May 18, 2017

LGTM

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 18, 2017
@ethantkoenig
Copy link
Member

ethantkoenig commented May 18, 2017

Let L-G-T-M work

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 18, 2017
@lunny
Copy link
Member

lunny commented May 19, 2017

Can we write some integration test for webhook?

@appleboy
Copy link
Member

appleboy commented May 19, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 19, 2017
@bkcsoft bkcsoft merged commit 977dcf9 into go-gitea:master May 19, 2017
@favadi favadi deleted the fix-wrong-after-field-pull-request branch May 19, 2017 13:52
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

Webhook: on merge wrong hash in the after field

6 participants

@favadi @ethantkoenig @lunny @appleboy @tboerger @bkcsoft