Fix renaming bug #1786
Merged
Fix renaming bug #1786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleboy
approved these changes
May 24, 2017
Member
|
LGTM |
tboerger
added
the
lgtm/need 1
Member
|
LGTM, but it's strange why the CI reported build success? |
tboerger
added
lgtm/done
Member
Author
|
@lunny Usages of the old variable name had been added to master between when the PR CI ran and when the PR was merged into master. |
Contributor
|
LGTM, even though it's already done 😄 |
Member
|
@ethantkoenig if another PR merged, the CI should be restarted again? |
Member
|
@lunny The CI only build master branch if PR merged. |
Member
Author
|
@lunny No, that would flood Drone (we already have a problem with CI jobs getting queued up) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix oversight from #1766