Skip to content

Don't show non-comments in comments API #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 1 commit into from
Jun 18, 2017
Merged

Don't show non-comments in comments API #2001

lunny merged 1 commit into from
Jun 18, 2017

Conversation

@ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Jun 18, 2017 •
edited
Loading

Fix the GET /repos/:owner/:repo/issues/:index/comments and GET /repos/:owner/:repo/issues/comments API endpoints to only return actual comments, and not "non-comment" comments (e.g. addition/removal of label)

Also add integration test.

@lunny lunny added the type/bug label Jun 18, 2017
@lunny lunny added this to the 1.2.0 milestone Jun 18, 2017
@lunny
Copy link
Member

lunny commented Jun 18, 2017

LGTM

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 18, 2017
@lafriks
Copy link
Member

lafriks commented Jun 18, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 18, 2017
@lunny lunny merged commit 255adc4 into go-gitea:master Jun 18, 2017
@ethantkoenig ethantkoenig deleted the fix/comment_api branch June 18, 2017 13:02
lunny added a commit to lunny/gitea that referenced this pull request Jun 20, 2017
@lunny
revert go-gitea#2001 and fix issue comments hidden
a91be46
lunny added a commit to lunny/gitea that referenced this pull request Jun 20, 2017
@lunny
fix go-gitea#2001
d530fa6
lunny added a commit that referenced this pull request Jun 21, 2017
@lunny
Fix #2001 and fix issue comments hidden (#2016)
d71fad2 
* revert #2001 and fix issue comments hidden

* fix #2001

* fix import

* improve comment type

* reduce unnecessary join

* fix comment on FindCommentsOptions
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ethantkoenig @lunny @lafriks @tboerger