Fix #2001 and fix issue comments hidden #2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
changed the title
Member
|
LGTM |
tboerger
added
the
lgtm/need 1
lafriks
reviewed
Jun 20, 2017
models/issue_comment.go
Outdated
| if opts.Since > 0 { | ||
| cond = cond.And(builder.Gte{"comment.updated_unix": opts.Since}) | ||
| } | ||
| if opts.Type > -1 { |
Member
There was a problem hiding this comment.
Probably it would be better to use opts.Type != CommentTypeUnknown in this case
ethantkoenig
suggested changes
Jun 20, 2017
models/issue_comment.go
Outdated
| cond = cond.And(builder.Eq{"issue.repo_id": opts.RepoID}) | ||
| } | ||
| if opts.IssueID > 0 { | ||
| cond = cond.And(builder.Eq{"issue.id": opts.IssueID}) |
Member
There was a problem hiding this comment.
Could use "comment.issue_id" instead of "issue.id", so that we can avoid joining if opts.RepoID is 0.
models/issue_comment.go
Outdated
| Asc("created_unix") | ||
| if since > 0 { | ||
| sess.And("updated_unix >= ?", since) | ||
| // FindCommentsOptions describes the condtions to Find comments |
models/issue_comment.go
Outdated
| sess.And("comment.updated_unix >= ?", since) | ||
| } | ||
| return comments, sess.Find(&comments) | ||
| return comments, e.Join("INNER", "issue", "issue.id = comment.issue_id"). |
Member
There was a problem hiding this comment.
The join is only necessary if opts.RepoID > 0, it would be preferable to only join when we have to.
ethantkoenig
approved these changes
Jun 20, 2017
Member
|
LGTM |
tboerger
added
lgtm/done
Member
Author
|
make L-G-T-M work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ethantkoenig