Fixed robots.txt 404 error #2226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
requested changes
Jul 29, 2017
routers/routes/routes.go
Outdated
| ctx.ServeFileContent(path.Join(setting.CustomPath, "robots.txt")) | ||
| } else { | ||
| ctx.Error(404) | ||
| ctx.Status(404) |
Member
There was a problem hiding this comment.
It is not fixing the problem, correct code would be ctx.Handle(404, "", nil)
Contributor
Author
There was a problem hiding this comment.
Sure? As I looked at other locations in the code where it returns a working 404.
Member
There was a problem hiding this comment.
I tried your code and it still returned empty 404 page
Contributor
Author
There was a problem hiding this comment.
Okay, changed it!
Member
There was a problem hiding this comment.
ctx.Status(404) is used only in API routes
lafriks
approved these changes
Jul 29, 2017
Member
|
LGTM |
bkcsoft
added
the
lgtm/need 1
appleboy
approved these changes
Jul 30, 2017
Member
|
LGTM |
bkcsoft
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #2210