From 53eb72c2c4741d9cdcfb0e0de9f436603d1b4a9a Mon Sep 17 00:00:00 2001 From: zeripath <art27@cantab.net> Date: Sun, 15 Jan 2023 14:33:25 +0000 Subject: [PATCH] Prevent panic on looking at api "git" endpoints for empty repos (#22457) Backport #22457 The API endpoints for "git" can panic if they are called on an empty repo. We can simply allow empty repos for these endpoints without worry as they should just work. Fix #22452 Signed-off-by: Andrew Thornton <art27@cantab.net> --- routers/api/v1/api.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/routers/api/v1/api.go b/routers/api/v1/api.go index 9f6bcf4f8589a..b0a864d199d2d 100644 --- a/routers/api/v1/api.go +++ b/routers/api/v1/api.go @@ -1042,7 +1042,7 @@ func Routes(ctx gocontext.Context) *web.Route { m.Get("/blobs/{sha}", repo.GetBlob) m.Get("/tags/{sha}", repo.GetAnnotatedTag) m.Get("/notes/{sha}", repo.GetNote) - }, context.ReferencesGitRepo(), reqRepoReader(unit.TypeCode)) + }, context.ReferencesGitRepo(true), reqRepoReader(unit.TypeCode)) m.Post("/diffpatch", reqRepoWriter(unit.TypeCode), reqToken(), bind(api.ApplyDiffPatchFileOptions{}), repo.ApplyDiffPatch) m.Group("/contents", func() { m.Get("", repo.GetContentsList)