Make short link pattern greedy #2259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
unit tests for this would be nice |
tboerger
added
the
lgtm/need 2
Multiple links on the same line are currently not recognized correctly.
Member
|
LGTM |
tboerger
added
lgtm/need 1
appleboy
approved these changes
Aug 5, 2017
Member
|
LGTM |
tboerger
added
lgtm/done
Member
|
@lunny Should we move this PR to milestone v1.2? |
Member
|
If unit test is added than yes I think |
Contributor
Author
|
@lafriks: I have added a unit test. Is this okay or do you expect something else/more? |
Member
|
@michaelkuhn yes excactly I was thinking about. Thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple links on the same line are currently not recognized correctly.
To reproduce, simply write something like this:
[[link1]] [[link2]]