Remove go version check for make fmt #2558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
added
backport/v1.2
topic/build
Codecov Report
@@ Coverage Diff @@
## master #2558 +/- ##
=======================================
Coverage 26.99% 26.99%
=======================================
Files 85 85
Lines 17097 17097
=======================================
Hits 4615 4615
Misses 11807 11807
Partials 675 675Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
Member
|
LGTM |
tboerger
added
lgtm/need 1
Member
|
We could simply use go1.7 tag on main.go ? This would drop support for 1.6 and below (even for compilation). |
Member
|
otherwise we should keep checking version for fmt and add 1.9 for required-gofmt-version. |
Contributor
|
LGTM |
tboerger
added
lgtm/done
Contributor
|
@sapk I think document which version are supported is enough. Otherwise will ever have to keep updating it for future versions of Go. |
lafriks
added a commit
to lafriks-fork/gitea
that referenced
this pull request
Sep 20, 2017
lunny
pushed a commit
that referenced
this pull request
Sep 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To not have problems with new versions of go