-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Update minimum password length requirements #25946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
techknowlogick
merged 6 commits into
go-gitea:main
from
techknowlogick:bump-min-pass-length
Aug 21, 2023
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e0f4717
Update minimum length requirements
techknowlogick 62818a2
Delete increase_min_pass_length.diff
techknowlogick ad8c3e7
Merge remote-tracking branch 'upstream/main' into bump-min-pass-length
techknowlogick bb2c917
increase min password len in e2e
techknowlogick 55abb45
pass is already 8 chars
techknowlogick 5d094d3
Merge branch 'main' into bump-min-pass-length
GiteaBot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| diff --git a/custom/conf/app.example.ini b/custom/conf/app.example.ini | ||
| index 83c713cb0..d3af33655 100644 | ||
| --- a/custom/conf/app.example.ini | ||
| +++ b/custom/conf/app.example.ini | ||
| @@ -454,7 +454,7 @@ INTERNAL_TOKEN= | ||
| ;REVERSE_PROXY_TRUSTED_PROXIES = 127.0.0.0/8,::1/128 | ||
| ;; | ||
| ;; The minimum password length for new Users | ||
| -;MIN_PASSWORD_LENGTH = 6 | ||
| +;MIN_PASSWORD_LENGTH = 8 | ||
| ;; | ||
| ;; Set to true to allow users to import local server paths | ||
| ;IMPORT_LOCAL_PATHS = false | ||
| diff --git a/docs/content/doc/administration/config-cheat-sheet.en-us.md b/docs/content/doc/administration/config-cheat-sheet.en-us.md | ||
| index 9c307cbc4..c79ae64c0 100644 | ||
| --- a/docs/content/doc/administration/config-cheat-sheet.en-us.md | ||
| +++ b/docs/content/doc/administration/config-cheat-sheet.en-us.md | ||
| @@ -561,7 +561,7 @@ And the following unique queues: | ||
| - `scrypt`: `scrypt$65536$16$2$50` | ||
| - Adjusting the algorithm parameters using this functionality is done at your own risk. | ||
| - `CSRF_COOKIE_HTTP_ONLY`: **true**: Set false to allow JavaScript to read CSRF cookie. | ||
| -- `MIN_PASSWORD_LENGTH`: **6**: Minimum password length for new users. | ||
| +- `MIN_PASSWORD_LENGTH`: **8**: Minimum password length for new users. | ||
| - `PASSWORD_COMPLEXITY`: **off**: Comma separated list of character classes required to pass minimum complexity. If left empty or no valid values are specified, checking is disabled (off): | ||
| - lower - use one or more lower latin characters | ||
| - upper - use one or more upper latin characters | ||
| diff --git a/modules/setting/security.go b/modules/setting/security.go | ||
| index 7064d7a00..90f614d4c 100644 | ||
| --- a/modules/setting/security.go | ||
| +++ b/modules/setting/security.go | ||
| @@ -124,7 +124,7 @@ func loadSecurityFrom(rootCfg ConfigProvider) { | ||
| ReverseProxyTrustedProxies = []string{"127.0.0.0/8", "::1/128"} | ||
| } | ||
|
|
||
| - MinPasswordLength = sec.Key("MIN_PASSWORD_LENGTH").MustInt(6) | ||
| + MinPasswordLength = sec.Key("MIN_PASSWORD_LENGTH").MustInt(8) | ||
| ImportLocalPaths = sec.Key("IMPORT_LOCAL_PATHS").MustBool(false) | ||
| DisableGitHooks = sec.Key("DISABLE_GIT_HOOKS").MustBool(true) | ||
| DisableWebhooks = sec.Key("DISABLE_WEBHOOKS").MustBool(false) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.