Skip to content

Remove duplicated button in Install web page #27941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 2 commits into from
Nov 7, 2023
Merged

Remove duplicated button in Install web page #27941

lunny merged 2 commits into from
Nov 7, 2023

Conversation

@lng2020
Copy link
Member

@lng2020 lng2020 commented Nov 7, 2023

Fix #27934
Regression #25648

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 7, 2023
@GiteaBot GiteaBot added this to the 1.20.6 milestone Nov 7, 2023
@lng2020 lng2020 mentioned this pull request Nov 7, 2023
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 7, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 7, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 7, 2023
@lunny lunny enabled auto-merge (squash) November 7, 2023 08:49
@lunny lunny merged commit 2978b43 into go-gitea:release/v1.20 Nov 7, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 7, 2023
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Nov 7, 2023

Wrong branch? The fix should be on main branch.

@lng2020
Copy link
Member Author

lng2020 commented Nov 7, 2023

Wrong branch? The fix should be on main branch.

The main branch is okay. I linked the wrong PR.
The PR linked is right but the manual backport to 1.20 of that PR forgets to delete these two lines.

@lng2020 lng2020 deleted the remove_dupilcate_button branch November 12, 2023 13:12
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.

Projects

None yet

Milestone

1.20.6

Development

Successfully merging this pull request may close these issues.

6 participants

@lng2020 @wxiaoguang @delvh @lunny @techknowlogick @GiteaBot