Skip to content

Do some missing checks (#28423) #28432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 2 commits into from
Dec 12, 2023
Merged

Do some missing checks (#28423) #28432

lunny merged 2 commits into from
Dec 12, 2023

Conversation

@lunny
Copy link
Member

@lunny lunny commented Dec 12, 2023

backport #28423

@lunny lunny added the type/bug label Dec 12, 2023
@lunny lunny added this to the 1.21.2 milestone Dec 12, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 12, 2023
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Dec 12, 2023
@lunny lunny requested review from wolfogre and wxiaoguang December 12, 2023 05:10
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 12, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 12, 2023
@lunny lunny enabled auto-merge (squash) December 12, 2023 05:51
@lunny lunny merged commit 265f485 into go-gitea:release/v1.21 Dec 12, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wolfogre wolfogre wolfogre approved these changes

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

+1 more reviewer

@Zettat123 Zettat123 Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug

Projects

None yet

Milestone

1.21.2

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny @wolfogre @Zettat123 @GiteaBot