Skip to content

Only delete scheduled workflows when needed #29091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 2 commits into from
Feb 8, 2024
Merged

Only delete scheduled workflows when needed #29091

lunny merged 2 commits into from
Feb 8, 2024

Conversation

@Zettat123
Copy link
Contributor

@Zettat123 Zettat123 commented Feb 8, 2024

Fix #29040

handleSchedules should be called only if DetectWorkflows should detect schedule workflows

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 8, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 8, 2024
@delvh delvh changed the title Fix the bug of workflow being deleted Do not delete scheduled workflows when not needed Feb 8, 2024
@delvh delvh changed the title Do not delete scheduled workflows when not needed Only delete scheduled workflows when needed Feb 8, 2024
@delvh delvh added the topic/gitea-actions related to the actions of Gitea label Feb 8, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 8, 2024
@lunny lunny enabled auto-merge (squash) February 8, 2024 12:35
@lunny lunny merged commit e600c35 into go-gitea:main Feb 8, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 8, 2024
@GiteaBot
Copy link
Collaborator

GiteaBot commented Feb 8, 2024

I was unable to create a backport for 1.21. @Zettat123, please send one manually. 🍵

go run ./contrib/backport 29091
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Feb 8, 2024
Zettat123 added a commit to Zettat123/gitea that referenced this pull request Feb 18, 2024
@Zettat123
Only delete scheduled workflows when needed (go-gitea#29091)
bcb3e0c 
Fix go-gitea#29040

`handleSchedules` should be called only if `DetectWorkflows` should
detect schedule workflows
@Zettat123 Zettat123 mentioned this pull request Feb 18, 2024
Merged
lunny pushed a commit that referenced this pull request Feb 18, 2024
@Zettat123
Only delete scheduled workflows when needed (#29091) (#29235)
7e0299b 
Backport #29091 

Fix #29040

`handleSchedules` should be called only if `DetectWorkflows` should
detect schedule workflows
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@Zettat123 @silverwind
Only delete scheduled workflows when needed (go-gitea#29091)
608cc97 
Fix go-gitea#29040

`handleSchedules` should be called only if `DetectWorkflows` should
detect schedule workflows
@wxiaoguang wxiaoguang added the backport/done All backports for this PR have been created label Feb 21, 2024
@github-actions
Copy link

github-actions bot commented Feb 29, 2024

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/gitea-actions related to the actions of Gitea type/bug

Projects

None yet

Milestone

1.22.0

Development

Successfully merging this pull request may close these issues.

schedule action task not work

5 participants

@Zettat123 @GiteaBot @lunny @delvh @wxiaoguang