Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Aug 18, 2024

Fix #31640

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 18, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Aug 18, 2024
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Aug 18, 2024
@lunny lunny force-pushed the lunny/fix_url_error branch from f22a326 to 6b51ffb Compare August 18, 2024 05:15
@github-actions github-actions bot removed the modifies/api This PR adds API routes or modifies them label Aug 18, 2024
@yp05327
Copy link
Contributor

yp05327 commented Aug 19, 2024

Mirror also has the same problem in L242.

@lunny
Copy link
Member Author

lunny commented Aug 19, 2024

Mirror also has the same problem in L242.

d88d02e

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 19, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 21, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 21, 2024
@lunny lunny enabled auto-merge (squash) August 21, 2024 01:25
@GiteaBot
Copy link
Collaborator

@lunny please fix the merge conflicts. 🍵

@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 21, 2024
@lunny lunny merged commit d158472 into go-gitea:main Aug 21, 2024
@GiteaBot GiteaBot added this to the 1.23.0 milestone Aug 21, 2024
@lunny lunny deleted the lunny/fix_url_error branch August 21, 2024 02:36
lunny added a commit to lunny/gitea that referenced this pull request Aug 21, 2024
@lunny lunny added the backport/done All backports for this PR have been created label Aug 21, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 24, 2024
* giteaofficial/main:
  Bump relative-time-element to v4.4.3 (go-gitea#31910)
  [skip ci] Updated translations via Crowdin
  Use correct function name (go-gitea#31887)
  Move lock icon position and add additional tooltips to branch list page (go-gitea#31839)
  Don't return 500 if mirror url contains special chars (go-gitea#31859)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTP 500 error when adding push mirror with invalid character in URL

4 participants