Filter reviews of one pull request in memory instead of database to reduce slow response because of lacking database index #33106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
performance/speed
GiteaBot
added
the
lgtm/need 2
…educe slow response because of lacking database index
lunny
force-pushed
the
lunny/fix_pr_view_loadreviewers
branch
from
654fa95 to
1235dbc
Compare
techknowlogick
approved these changes
Jan 5, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Jan 6, 2025
wxiaoguang
reviewed
Jan 6, 2025
wxiaoguang
reviewed
Jan 6, 2025
wxiaoguang
reviewed
Jan 7, 2025
wxiaoguang
reviewed
Jan 7, 2025
wxiaoguang
approved these changes
Jan 7, 2025
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jan 7, 2025
…educe slow response because of lacking database index (go-gitea#33106) This PR fixes a performance problem when reviewing a pull request in a big instance which have many records in the `review` table. Traditionally, we should add more indexes in that table. But since dismissed reviews of 1 pull request will not be too many as expected in a common repository. Filtering reviews in the memory should be more quick . --------- Co-authored-by: wxiaoguang <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 8, 2025
* giteaofficial/main: add submodule diff links (go-gitea#33097) [skip ci] Updated translations via Crowdin Update status check for all supported on.pull_request.types in Gitea (go-gitea#33117) Support the new exit code for `git remote` subcommands for git version >=2.30.0 (go-gitea#33129) Make git clone URL could use current signed-in user (go-gitea#33091) Filter reviews of one pull request in memory instead of database to reduce slow response because of lacking database index (go-gitea#33106)
lunny
added a commit
that referenced
this pull request
Jan 8, 2025
…educe slow response because of lacking database index (#33106) (#33128) Backport #33106 by @lunny This PR fixes a performance problem when reviewing a pull request in a big instance which have many records in the `review` table. Traditionally, we should add more indexes in that table. But since dismissed reviews of 1 pull request will not be too many as expected in a common repository. Filtering reviews in the memory should be more quick . Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a performance problem when reviewing a pull request in a big instance which have many records in the
reviewtable. Traditionally, we should add more indexes in that table. But since dismissed reviews of 1 pull request will not be too many as expected in a common repository. Filtering reviews in the memory should be more quick .