Skip to content

Fix incorrect comment diff hunk parsing, fix github asset ID nil panic #35046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lunny merged 6 commits into from
Jul 11, 2025
Merged

Fix incorrect comment diff hunk parsing, fix github asset ID nil panic #35046

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8f8ca4e
Fix a bug that the code diff hunk missing one at
lunny Jul 11, 2025
806f915
fix getDiffLineSectionInfo
wxiaoguang Jul 11, 2025
fdac8bd
fix github migration asset ID nil panic
wxiaoguang Jul 11, 2025
0ed2e89
Merge branch 'main' into lunny/fix_hunk_missing_at
wxiaoguang Jul 11, 2025
7611881
correct
wxiaoguang Jul 11, 2025
d11faa5
more bug comment
wxiaoguang Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/gitdiff/gitdiff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ func (diffSection *DiffSection) GetComputedInlineDiffFor(diffLine *DiffLine, loc
// try to find equivalent diff line. ignore, otherwise
switch diffLine.Type {
case DiffLineSection:
return getLineContent(diffLine.Content[1:], locale)
return getLineContent(diffLine.Content, locale)
case DiffLineAdd:
compareDiffLine := diffSection.GetLine(diffLine.Match)
return diffSection.getDiffLineForRender(DiffLineAdd, compareDiffLine, diffLine, locale)
Expand Down