Skip to content

Conversation

@dl5rcw
Copy link

@dl5rcw dl5rcw commented Dec 28, 2016

@strk asked me to offer my gogs contribution to gitea
gogs/gogs#3785

Setup:
I use gogs // gitea with reverse proxy and basic auth. Users are auto created.
http pull and push did not work, so I started to look in the code.

We use SSO (AuthBasicProvider dbd, Apache 2.4, Location /gogs - since today /gitea AuthType Basic)
Reverse Proxy is pointing to /gogs - since today /gitea.
[security]
REVERSE_PROXY_AUTHENTICATION_USER = X-WEBAUTH-USER
[service]
ENABLE_REVERSE_PROXY_AUTHENTICATION = true
ENABLE_REVERSE_PROXY_AUTO_REGISTRATION = true

Issue: SSO was not handeled by http.go
Solution: now added to the section, see contribution.

@lunny lunny added this to the 1.1.0 milestone Dec 29, 2016
@lunny lunny added type/enhancement An improvement of existing functionality type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Dec 29, 2016
@strk
Copy link
Member

strk commented Dec 29, 2016

LGTM, but I hadn't tested it

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 29, 2016
@dl5rcw
Copy link
Author

dl5rcw commented Dec 29, 2016

It is in production mode on our server now.

@dl5rcw
Copy link
Author

dl5rcw commented Dec 29, 2016

Dear all,
for those to review, please focus on line 86 to 97. https://gist.github.com/dl5rcw/2dd2dac42ee46996c3e7166ba15b3b38
Everything else is indentation. Lint would complain causing the check to fail. Fixing the indentation makes the diff look big - which it is not when having a second glance on it.

@bkcsoft
Copy link
Member

bkcsoft commented Dec 29, 2016

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 29, 2016
@bkcsoft bkcsoft merged commit 37eec6c into go-gitea:master Dec 29, 2016
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants