Skip to content

Add X-GitHub-* headers #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 1 commit into from
Feb 2, 2017
Merged

Add X-GitHub-* headers #809

lunny merged 1 commit into from
Feb 2, 2017

Conversation

@kanocz
Copy link
Contributor

@kanocz kanocz commented Feb 1, 2017

clubhouse.io has "GitHub integration", Gitea webhooks payload is almost identical to GitHub's one, but they require X-GitHub-* headers to work. By adding this aliases Gitea can be used with clubhouse.io without any problems

thibaultmeyer
thibaultmeyer reviewed Feb 1, 2017
View reviewed changes
models/webhook.go

timeout := time.Duration(setting.Webhook.DeliverTimeout) * time.Second
req := httplib.Post(t.URL).SetTimeout(timeout, timeout).
Header("X-Gogs-Delivery", t.UUID).
Copy link
Contributor

@thibaultmeyer thibaultmeyer Feb 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lunny, @bkcsoft Maybe change from X-Gogs-* to X-Gitea-* in another PR ?

Copy link
Member

@lunny lunny Feb 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's OK.

@tboerger
Copy link
Member

tboerger commented Feb 1, 2017

I don't believe that this will be enough to get integrated within clubhouse.io?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 1, 2017
@kanocz
Copy link
Contributor Author

kanocz commented Feb 1, 2017

@tboerger without this patch I got {"message":"Missing value for header x-github-delivery"} answer from clubhouse.io, but after adding this headers it works (tested only for push events)

@tboerger tboerger added the type/enhancement An improvement of existing functionality label Feb 1, 2017
@tboerger tboerger added this to the 1.1.0 milestone Feb 1, 2017
@lunny
Copy link
Member

lunny commented Feb 1, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 1, 2017
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 2, 2017
@appleboy
Copy link
Member

appleboy commented Feb 2, 2017

LGTM

@lunny lunny merged commit 79ab69f into go-gitea:master Feb 2, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny left review comments

+2 more reviewers

@thibaultmeyer thibaultmeyer thibaultmeyer left review comments

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@kanocz @tboerger @lunny @appleboy @thibaultmeyer