Skip to content

Handle SetModel error, fixes one errcheck report (#257) #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 1 commit into from
Feb 19, 2017
Merged

Handle SetModel error, fixes one errcheck report (#257) #957

lunny merged 1 commit into from
Feb 19, 2017

Conversation

@lunny
Copy link
Member

@lunny lunny commented Feb 16, 2017

backport from #589

@lunny lunny added the type/enhancement An improvement of existing functionality label Feb 16, 2017
@lunny lunny added this to the 1.0.2 milestone Feb 16, 2017
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 16, 2017
@appleboy
Copy link
Member

appleboy commented Feb 16, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 16, 2017
@ethantkoenig
Copy link
Member

ethantkoenig commented Feb 17, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 17, 2017
@lunny lunny merged commit 023a660 into go-gitea:release/v1.0 Feb 19, 2017
@lunny lunny deleted the lunny/errcheck-admin branch February 19, 2017 02:12
@tboerger tboerger added the backport/done All backports for this PR have been created label Feb 21, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.0.2

Development

Successfully merging this pull request may close these issues.

5 participants

@lunny @appleboy @ethantkoenig @tboerger @strk