Skip to content

CI lint and reduce job expansion #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

fredbi
Copy link
Member

@fredbi fredbi commented Nov 16, 2020

No description provided.

* for ppc arch, run only the main test suite, without long running tests

Signed-off-by: Frederic BIDON <[email protected]>
* reduced CI expanded matrix: ppc job only runs on latest golang, with shortened test suite
* updated golangci config
* addressed a few linting issues

> NOTE: the #nosec hints added work around the detection of actual "code smells", but not necessarily bugs
> (passing a pointer to a value obtained from a range operator). Cleaning this more thoroughly remains
> a todo.

Signed-off-by: Frederic BIDON <[email protected]>
@fredbi fredbi changed the title Ci reduce job expansion CI lint and reduce job expansion Nov 16, 2020
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #129 (0af19e0) into master (15b6e50) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   97.25%   97.25%           
=======================================
  Files          20       20           
  Lines        1928     1928           
=======================================
  Hits         1875     1875           
  Misses         46       46           
  Partials        7        7           
Impacted Files Coverage Δ
object_validator.go 97.84% <ø> (ø)
rexp.go 100.00% <ø> (ø)
schema.go 100.00% <ø> (ø)
schema_props.go 100.00% <ø> (ø)
spec_messages.go 98.07% <ø> (ø)
validator.go 100.00% <ø> (ø)
default_validator.go 100.00% <100.00%> (ø)
example_validator.go 100.00% <100.00%> (ø)
helpers.go 96.07% <100.00%> (ø)
spec.go 98.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b6e50...0af19e0. Read the comment docs.

@fredbi fredbi requested a review from casualjim November 16, 2020 15:04
@fredbi
Copy link
Member Author

fredbi commented Nov 16, 2020

validate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant