Improve some things around how errors are logged when parsing a file

Author: Jon Poole

compile/compile.go

@@ -9,6 +9,7 @@ package compile
 // FIXME kill ast.Identifier and turn into string?
 
 import (
+	"bytes"
 	"fmt"
 	"log"
 	"strings"
@@ -107,7 +108,7 @@ func init() {
 // in addition to any features explicitly specified.
 func Compile(src, srcDesc string, mode py.CompileMode, futureFlags int, dont_inherit bool) (*py.Code, error) {
 	// Parse Ast
-	Ast, err := parser.ParseString(src, mode)
+	Ast, err := parser.Parse(bytes.NewBufferString(src), srcDesc, mode)
 	if err != nil {
 		return nil, err
 	}

main.go

@@ -78,7 +78,7 @@ func xmain(args []string) {
 		_, err := py.RunFile(ctx, args[0], py.CompileOpts{}, nil)
 		if err != nil {
 			py.TracebackDump(err)
-			log.Fatal(err)
+			os.Exit(1)
 		}
 	}
 }

parser/lexer.go

@@ -916,7 +916,7 @@ func (x *yyLex) SyntaxErrorf(format string, a ...interface{}) {
 func (x *yyLex) ErrorReturn() error {
 	if x.error {
 		if x.errorString == "" {
-			if x.eof && x.interactive {
+			if x.eof {
 				x.errorString = "unexpected EOF while parsing"
 			} else {
 				x.errorString = "invalid syntax"

py/traceback.go

@@ -64,10 +64,10 @@ func TracebackDump(err interface{}) {
 	case *ExceptionInfo:
 		e.TracebackDump(os.Stderr)
 	case *Exception:
-		fmt.Fprintf(os.Stderr, "Exception %#v\n", e)
+		fmt.Fprintf(os.Stderr, "Exception %v\n", e)
 		fmt.Fprintf(os.Stderr, "-- No traceback available --\n")
 	default:
-		fmt.Fprintf(os.Stderr, "Error %#v\n", err)
+		fmt.Fprintf(os.Stderr, "Error %v\n", err)
 		fmt.Fprintf(os.Stderr, "-- No traceback available --\n")
 	}
 }