Skip to content

Commit 4de4799

Browse files
authored
fix: ensure tmp folder is present on docker container (#910)
* chore: add logger to bookmark update cache * ensure there's a tmp folder in the container
1 parent 647945c commit 4de4799

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

Dockerfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ ARG TARGETOS
88
ARG TARGETVARIANT
99
COPY dist/shiori_${TARGETOS}_${TARGETARCH}${TARGETVARIANT}/shiori /usr/bin/shiori
1010
RUN apk add --no-cache ca-certificates tzdata && \
11-
chmod +x /usr/bin/shiori
11+
chmod +x /usr/bin/shiori && \
12+
rm -rf /tmp/*
1213

1314
# Server image
1415
FROM scratch
@@ -20,6 +21,7 @@ WORKDIR ${SHIORI_DIR}
2021
LABEL org.opencontainers.image.source="https://github.com/go-shiori/shiori"
2122
LABEL maintainer="Felipe Martin <github@fmartingr.com>"
2223

24+
COPY --from=builder /tmp /tmp
2325
COPY --from=builder /usr/bin/shiori /usr/bin/shiori
2426
COPY --from=builder /usr/share/zoneinfo /usr/share/zoneinfo
2527
COPY --from=builder /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt

internal/http/routes/api/v1/bookmarks.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,11 @@ func (r *BookmarksAPIRoutes) updateCache(c *gin.Context) {
217217
content.Close()
218218

219219
if err != nil {
220+
r.logger.WithFields(logrus.Fields{
221+
"bookmark_id": book.ID,
222+
"url": book.URL,
223+
"error": err,
224+
}).Error("error downloading bookmark cache")
220225
chProblem <- book.ID
221226
return
222227
}

0 commit comments

Comments
 (0)