Skip to content

database/sql: feedback for non-DSN DB opener #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kardianos opened this issue Aug 15, 2017 · 1 comment
Closed

database/sql: feedback for non-DSN DB opener #650

kardianos opened this issue Aug 15, 2017 · 1 comment
Labels
database/sql issue

Comments

@kardianos
Copy link

Related Issue: golang/go#20268
CL: https://go-review.googlesource.com/c/53430

There are two general ways we are considering supporting non-DSN opens.

The current CL has a Connector that is separate from the driver instance. I have a suspicion that it might be better to have the Connector be part of the Driver interface (see the CL comments).

Your feedback on this issue, CL, or the Go issue would be appreciated.
@julienschmidt
Copy link
Member

See #671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
database/sql issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kardianos @julienschmidt