Add property accessors, types.

Author: GirlBossRush

web/package.json

@@ -72,6 +72,7 @@
         "#tests/*": "./tests/*.js",
         "#e2e": "./e2e/index.ts",
         "#e2e/*": "./e2e/*.ts",
+        "#types/*": "./types/*/index.d.ts",
         "#*/browser": {
             "types": "./out/*/browser.d.ts",
             "import": "./*/browser.js"

web/src/admin/applications/ApplicationCheckAccessForm.ts

@@ -24,13 +24,13 @@ import PFDescriptionList from "@patternfly/patternfly/components/DescriptionList
 @customElement("ak-application-check-access-form")
 export class ApplicationCheckAccessForm extends Form<{ forUser: number }> {
     @property({ attribute: false })
-    application!: Application;
+    public application!: Application;
 
     @property({ attribute: false })
-    result: PolicyTestResult | null = null;
+    public result: PolicyTestResult | null = null;
 
     @property({ attribute: false })
-    request?: number;
+    public request?: number;
 
     getSuccessMessage(): string {
         return msg("Successfully sent test-request.");
@@ -45,7 +45,7 @@ export class ApplicationCheckAccessForm extends Form<{ forUser: number }> {
         return (this.result = result);
     }
 
-    reset(): void {
+    public override reset(): void {
         super.reset();
         this.result = null;
     }

web/src/admin/applications/ApplicationForm.ts

@@ -57,7 +57,7 @@ export class ApplicationForm extends WithCapabilitiesConfig(ModelForm<Applicatio
     @state()
     protected backchannelProviders: Provider[] = [];
 
-    reset(): void {
+    public override reset(): void {
         super.reset();
         this.backchannelProviders = [];
     }

web/src/admin/blueprints/BlueprintForm.ts

@@ -22,31 +22,32 @@ import { ifDefined } from "lit/directives/if-defined.js";
 
 import PFContent from "@patternfly/patternfly/components/Content/content.css";
 
-enum blueprintSource {
-    file = "file",
-    oci = "oci",
-    internal = "internal",
+enum BlueprintSource {
+    File = "file",
+    OCI = "oci",
+    Internal = "internal",
 }
 
 @customElement("ak-blueprint-form")
 export class BlueprintForm extends ModelForm<BlueprintInstance, string> {
     @state()
-    source: blueprintSource = blueprintSource.file;
+    protected source: BlueprintSource = BlueprintSource.File;
 
-    reset(): void {
+    public override reset(): void {
         super.reset();
-        this.source = blueprintSource.file;
+
+        this.source = BlueprintSource.File;
     }
 
     async loadInstance(pk: string): Promise<BlueprintInstance> {
         const inst = await new ManagedApi(DEFAULT_CONFIG).managedBlueprintsRetrieve({
             instanceUuid: pk,
         });
         if (inst.path?.startsWith("oci://")) {
-            this.source = blueprintSource.oci;
+            this.source = BlueprintSource.OCI;
         }
         if (inst.content !== "") {
-            this.source = blueprintSource.internal;
+            this.source = BlueprintSource.Internal;
         }
         return inst;
     }
@@ -91,17 +92,17 @@ export class BlueprintForm extends ModelForm<BlueprintInstance, string> {
                 <div class="pf-c-card__body">
                     <ak-toggle-group
                         value=${this.source}
-                        @ak-toggle=${(ev: CustomEvent<{ value: blueprintSource }>) => {
+                        @ak-toggle=${(ev: CustomEvent<{ value: BlueprintSource }>) => {
                             this.source = ev.detail.value;
                         }}
                     >
-                        <option value=${blueprintSource.file}>${msg("Local path")}</option>
-                        <option value=${blueprintSource.oci}>${msg("OCI Registry")}</option>
-                        <option value=${blueprintSource.internal}>${msg("Internal")}</option>
+                        <option value=${BlueprintSource.File}>${msg("Local path")}</option>
+                        <option value=${BlueprintSource.OCI}>${msg("OCI Registry")}</option>
+                        <option value=${BlueprintSource.Internal}>${msg("Internal")}</option>
                     </ak-toggle-group>
                 </div>
                 <div class="pf-c-card__footer">
-                    ${this.source === blueprintSource.file
+                    ${this.source === BlueprintSource.File
                         ? html`<ak-form-element-horizontal label=${msg("Path")} name="path">
                               <ak-search-select
                                   .fetchObjects=${async (
@@ -132,7 +133,7 @@ export class BlueprintForm extends ModelForm<BlueprintInstance, string> {
                               </ak-search-select>
                           </ak-form-element-horizontal>`
                         : nothing}
-                    ${this.source === blueprintSource.oci
+                    ${this.source === BlueprintSource.OCI
                         ? html` <ak-text-input
                               name="path"
                               label=${msg("OCI URL")}
@@ -164,7 +165,7 @@ export class BlueprintForm extends ModelForm<BlueprintInstance, string> {
                           >
                           </ak-text-input>`
                         : nothing}
-                    ${this.source === blueprintSource.internal
+                    ${this.source === BlueprintSource.Internal
                         ? html`<ak-form-element-horizontal label=${msg("Blueprint")} name="content">
                               <ak-codemirror
                                   mode="yaml"

web/src/admin/endpoints/connectors/agent/EnrollmentTokenForm.ts

@@ -37,8 +37,9 @@ export class EnrollmentTokenForm extends WithBrandConfig(ModelForm<EnrollmentTok
     @property({ type: String, attribute: "connector-id" })
     public connectorID?: string;
 
-    reset(): void {
+    public override reset(): void {
         super.reset();
+
         this.expiresAt = new Date(Date.now() + EXPIRATION_DURATION);
     }
 

web/src/admin/enterprise/EnterpriseLicenseForm.ts

@@ -6,22 +6,23 @@ import { DEFAULT_CONFIG } from "#common/api/config";
 import { EVENT_REFRESH_ENTERPRISE } from "#common/constants";
 
 import { ModelForm } from "#elements/forms/ModelForm";
+import { ifPresent } from "#elements/utils/attributes";
 
 import { EnterpriseApi, License } from "@goauthentik/api";
 
 import { msg } from "@lit/localize";
 import { html, TemplateResult } from "lit";
 import { customElement, state } from "lit/decorators.js";
-import { ifDefined } from "lit/directives/if-defined.js";
 
 @customElement("ak-enterprise-license-form")
 export class EnterpriseLicenseForm extends ModelForm<License, string> {
     @state()
-    installID?: string;
+    protected installID: string | null = null;
 
-    reset(): void {
+    public override reset(): void {
         super.reset();
-        this.installID = undefined;
+
+        this.installID = null;
     }
 
     loadInstance(pk: string): Promise<License> {
@@ -66,7 +67,7 @@ export class EnterpriseLicenseForm extends ModelForm<License, string> {
                     spellcheck="false"
                     readonly
                     type="text"
-                    value="${ifDefined(this.installID)}"
+                    value="${ifPresent(this.installID)}"
                 />
             </ak-form-element-horizontal>
             <ak-secret-textarea-input

web/src/admin/files/FileUploadForm.ts

@@ -61,8 +61,9 @@ export class FileUploadForm extends Form<Record<string, unknown>> {
 
     #formRef = createRef<HTMLFormElement>();
 
-    reset(): void {
+    public override reset(): void {
         super.reset();
+
         this.selectedFile = null;
     }
 

web/src/admin/flows/FlowImportForm.ts

@@ -20,20 +20,21 @@ import PFDescriptionList from "@patternfly/patternfly/components/DescriptionList
 
 @customElement("ak-flow-import-form")
 export class FlowImportForm extends Form<Flow> {
+    static styles: CSSResult[] = [...super.styles, PFDescriptionList];
+
     @state()
-    result?: FlowImportResult;
+    protected result: FlowImportResult | null = null;
 
-    reset(): void {
+    public override reset(): void {
         super.reset();
-        this.result = undefined;
+
+        this.result = null;
     }
 
     getSuccessMessage(): string {
         return msg("Successfully imported flow.");
     }
 
-    static styles: CSSResult[] = [...super.styles, PFDescriptionList];
-
     async send(): Promise<FlowImportResult> {
         const file = this.files().get("flow");
         if (!file) {

web/src/admin/flows/StageBindingForm.ts

@@ -61,13 +61,14 @@ export class StageBindingForm extends ModelForm<FlowStageBinding, string> {
     }
 
     @property()
-    targetPk?: string;
+    public targetPk?: string;
 
     @state()
-    defaultOrder = 0;
+    protected defaultOrder = 0;
 
-    reset(): void {
+    public override reset(): void {
         super.reset();
+
         this.defaultOrder = 0;
     }
 

web/src/admin/outposts/OutpostForm.ts

@@ -106,8 +106,9 @@ export class OutpostForm extends ModelForm<Outpost, string> {
 
     defaultConfig?: OutpostDefaultConfig;
 
-    reset(): void {
+    public override reset(): void {
         super.reset();
+
         this.type = OutpostTypeEnum.Proxy;
         this.providers = providerProvider(this.type);
     }