remove all const

Author: goderbauer

analysis_options.yaml

@@ -154,10 +154,10 @@ linter:
     # - prefer_asserts_with_message # not required by flutter style
     - prefer_collection_literals
     - prefer_conditional_assignment
-    - prefer_const_constructors
+    # - prefer_const_constructors
     - prefer_const_constructors_in_immutables
-    - prefer_const_declarations
-    - prefer_const_literals_to_create_immutables
+    # - prefer_const_declarations
+    # - prefer_const_literals_to_create_immutables
     # - prefer_constructors_over_static_methods # far too many false positives
     - prefer_contains
     # - prefer_double_quotes # opposite of prefer_single_quotes

dev/integration_tests/new_gallery/lib/constants.dart

@@ -7,36 +7,36 @@
 import 'dart:typed_data';
 
 // Height of the 'Gallery' header
-const double galleryHeaderHeight = 64;
+double galleryHeaderHeight = 64;
 
 // The font size delta for headline4 font.
-const double desktopDisplay1FontDelta = 16;
+double desktopDisplay1FontDelta = 16;
 
 // The width of the settingsDesktop.
-const double desktopSettingsWidth = 520;
+double desktopSettingsWidth = 520;
 
 // Sentinel value for the system text scale factor option.
-const double systemTextScaleFactorOption = -1;
+double systemTextScaleFactorOption = -1;
 
 // The splash page animation duration.
-const Duration splashPageAnimationDuration = Duration(milliseconds: 300);
+Duration splashPageAnimationDuration = Duration(milliseconds: 300);
 
 // Half the splash page animation duration.
-const Duration halfSplashPageAnimationDuration = Duration(milliseconds: 150);
+Duration halfSplashPageAnimationDuration = Duration(milliseconds: 150);
 
 // Duration for settings panel to open on mobile.
-const Duration settingsPanelMobileAnimationDuration =
+Duration settingsPanelMobileAnimationDuration =
     Duration(milliseconds: 200);
 
 // Duration for settings panel to open on desktop.
-const Duration settingsPanelDesktopAnimationDuration =
+Duration settingsPanelDesktopAnimationDuration =
     Duration(milliseconds: 600);
 
 // Duration for home page elements to fade in.
-const Duration entranceAnimationDuration = Duration(milliseconds: 200);
+Duration entranceAnimationDuration = Duration(milliseconds: 200);
 
 // The desktop top padding for a page's first header (e.g. Gallery, Settings)
-const double firstHeaderDesktopTopPadding = 5.0;
+double firstHeaderDesktopTopPadding = 5.0;
 
 // A transparent image used to avoid loading images when they are not needed.
 final Uint8List kTransparentImage = Uint8List.fromList(<int>[

dev/integration_tests/new_gallery/lib/data/demos.dart

@@ -32,8 +32,8 @@ import '../gallery_localizations.dart';
 import '../gallery_localizations_en.dart';
 import 'icons.dart';
 
-const String _docsBaseUrl = 'https://api.flutter.dev/flutter';
-const String _docsAnimationsUrl =
+String _docsBaseUrl = 'https://api.flutter.dev/flutter';
+String _docsAnimationsUrl =
     'https://pub.dev/documentation/animations/latest/animations';
 
 enum GalleryDemoCategory {
@@ -57,7 +57,7 @@ enum GalleryDemoCategory {
 }
 
 class GalleryDemo {
-  const GalleryDemo({
+  GalleryDemo({
     required this.title,
     required this.category,
     required this.subtitle,
@@ -83,11 +83,11 @@ class GalleryDemo {
 }
 
 TextSpan noOpCodeDisplayer(BuildContext context) {
-  return const TextSpan(text: '');
+  return TextSpan(text: '');
 }
 
 class GalleryDemoConfiguration {
-  const GalleryDemoConfiguration({
+  GalleryDemoConfiguration({
     required this.title,
     required this.description,
     required this.documentationUrl,
@@ -1176,35 +1176,35 @@ class Demos {
             description: localizations.demoSharedAxisDescription,
             documentationUrl:
                 '$_docsAnimationsUrl/SharedAxisTransition-class.html',
-            buildRoute: (_) => const SharedXAxisTransitionDemo(),
+            buildRoute: (_) => SharedXAxisTransitionDemo(),
                       ),
           GalleryDemoConfiguration(
             title: localizations.demoSharedYAxisTitle,
             description: localizations.demoSharedAxisDescription,
             documentationUrl:
                 '$_docsAnimationsUrl/SharedAxisTransition-class.html',
-            buildRoute: (_) => const SharedYAxisTransitionDemo(),
+            buildRoute: (_) => SharedYAxisTransitionDemo(),
                       ),
           GalleryDemoConfiguration(
             title: localizations.demoSharedZAxisTitle,
             description: localizations.demoSharedAxisDescription,
             documentationUrl:
                 '$_docsAnimationsUrl/SharedAxisTransition-class.html',
-            buildRoute: (_) => const SharedZAxisTransitionDemo(),
+            buildRoute: (_) => SharedZAxisTransitionDemo(),
                       ),
           GalleryDemoConfiguration(
             title: localizations.demoFadeThroughTitle,
             description: localizations.demoFadeThroughDescription,
             documentationUrl:
                 '$_docsAnimationsUrl/FadeThroughTransition-class.html',
-            buildRoute: (_) => const FadeThroughTransitionDemo(),
+            buildRoute: (_) => FadeThroughTransitionDemo(),
                       ),
           GalleryDemoConfiguration(
             title: localizations.demoFadeScaleTitle,
             description: localizations.demoFadeScaleDescription,
             documentationUrl:
                 '$_docsAnimationsUrl/FadeScaleTransition-class.html',
-            buildRoute: (_) => const FadeScaleTransitionDemo(),
+            buildRoute: (_) => FadeScaleTransitionDemo(),
                       ),
         ],
         category: GalleryDemoCategory.other,

dev/integration_tests/new_gallery/lib/data/gallery_options.dart

@@ -16,7 +16,7 @@ enum CustomTextDirection {
 }
 
 // See http://en.wikipedia.org/wiki/Right-to-left
-const List<String> rtlLanguages = <String>[
+List<String> rtlLanguages = <String>[
   'ar', // Arabic
   'fa', // Farsi
   'he', // Hebrew
@@ -25,7 +25,7 @@ const List<String> rtlLanguages = <String>[
 ];
 
 // Fake locale to represent the system Locale option.
-const Locale systemLocaleOption = Locale('system');
+Locale systemLocaleOption = Locale('system');
 
 Locale? _deviceLocale;
 
@@ -247,7 +247,7 @@ class _ModelBindingState extends State<ModelBinding> {
         // We delay the time dilation change long enough that the user can see
         // that UI has started reacting and then we slam on the brakes so that
         // they see that the time is in fact now dilated.
-        _timeDilationTimer = Timer(const Duration(milliseconds: 150), () {
+        _timeDilationTimer = Timer(Duration(milliseconds: 150), () {
           timeDilation = newModel.timeDilation;
         });
       } else {

dev/integration_tests/new_gallery/lib/data/icons.dart

@@ -7,168 +7,168 @@ import 'package:flutter/material.dart';
 class GalleryIcons {
   GalleryIcons._();
 
-  static const IconData tooltip = IconData(
+  static IconData tooltip = IconData(
     0xe900,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData textFieldsAlt = IconData(
+  static IconData textFieldsAlt = IconData(
     0xe901,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData tabs = IconData(
+  static IconData tabs = IconData(
     0xe902,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData switches = IconData(
+  static IconData switches = IconData(
     0xe903,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData sliders = IconData(
+  static IconData sliders = IconData(
     0xe904,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData shrine = IconData(
+  static IconData shrine = IconData(
     0xe905,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData sentimentVerySatisfied = IconData(
+  static IconData sentimentVerySatisfied = IconData(
     0xe906,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData refresh = IconData(
+  static IconData refresh = IconData(
     0xe907,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData progressActivity = IconData(
+  static IconData progressActivity = IconData(
     0xe908,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData phoneIphone = IconData(
+  static IconData phoneIphone = IconData(
     0xe909,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData pageControl = IconData(
+  static IconData pageControl = IconData(
     0xe90a,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData moreVert = IconData(
+  static IconData moreVert = IconData(
     0xe90b,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData menu = IconData(
+  static IconData menu = IconData(
     0xe90c,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData listAlt = IconData(
+  static IconData listAlt = IconData(
     0xe90d,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData gridOn = IconData(
+  static IconData gridOn = IconData(
     0xe90e,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData expandAll = IconData(
+  static IconData expandAll = IconData(
     0xe90f,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData event = IconData(
+  static IconData event = IconData(
     0xe910,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData driveVideo = IconData(
+  static IconData driveVideo = IconData(
     0xe911,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData dialogs = IconData(
+  static IconData dialogs = IconData(
     0xe912,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData dataTable = IconData(
+  static IconData dataTable = IconData(
     0xe913,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData customTypography = IconData(
+  static IconData customTypography = IconData(
     0xe914,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData colors = IconData(
+  static IconData colors = IconData(
     0xe915,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData chips = IconData(
+  static IconData chips = IconData(
     0xe916,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData checkBox = IconData(
+  static IconData checkBox = IconData(
     0xe917,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData cards = IconData(
+  static IconData cards = IconData(
     0xe918,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData buttons = IconData(
+  static IconData buttons = IconData(
     0xe919,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData bottomSheets = IconData(
+  static IconData bottomSheets = IconData(
     0xe91a,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData bottomNavigation = IconData(
+  static IconData bottomNavigation = IconData(
     0xe91b,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData animation = IconData(
+  static IconData animation = IconData(
     0xe91c,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData accountBox = IconData(
+  static IconData accountBox = IconData(
     0xe91d,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData snackbar = IconData(
+  static IconData snackbar = IconData(
     0xe91e,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData categoryMdc = IconData(
+  static IconData categoryMdc = IconData(
     0xe91f,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData cupertinoProgress = IconData(
+  static IconData cupertinoProgress = IconData(
     0xe920,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData cupertinoPullToRefresh = IconData(
+  static IconData cupertinoPullToRefresh = IconData(
     0xe921,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData cupertinoSwitch = IconData(
+  static IconData cupertinoSwitch = IconData(
     0xe922,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData genericButtons = IconData(
+  static IconData genericButtons = IconData(
     0xe923,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData backdrop = IconData(
+  static IconData backdrop = IconData(
     0xe924,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData bottomAppBar = IconData(
+  static IconData bottomAppBar = IconData(
     0xe925,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData bottomSheetPersistent = IconData(
+  static IconData bottomSheetPersistent = IconData(
     0xe926,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData listsLeaveBehind = IconData(
+  static IconData listsLeaveBehind = IconData(
     0xe927,
     fontFamily: 'GalleryIcons',
   );
-  static const IconData navigationRail = Icons.vertical_split;
-  static const IconData appbar = Icons.web_asset;
-  static const IconData divider = Icons.credit_card;
-  static const IconData search = Icons.search;
+  static IconData navigationRail = Icons.vertical_split;
+  static IconData appbar = Icons.web_asset;
+  static IconData divider = Icons.credit_card;
+  static IconData search = Icons.search;
 }