Skip to content

Commit 8b7470d

Browse files
authored
perf: quick way to validate token string (#302)
1 parent 873d96d commit 8b7470d

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

parser.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,6 @@ func (p *Parser) ParseUnverified(tokenString string, claims Claims) (token *Toke
130130
// parse Header
131131
var headerBytes []byte
132132
if headerBytes, err = p.DecodeSegment(parts[0]); err != nil {
133-
if strings.HasPrefix(strings.ToLower(tokenString), "bearer ") {
134-
return token, parts, newError("tokenstring should not contain 'bearer '", ErrTokenMalformed)
135-
}
136133
return token, parts, newError("could not base64 decode header", ErrTokenMalformed, err)
137134
}
138135
if err = json.Unmarshal(headerBytes, &token.Header); err != nil {

request/extractor.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ func (e BearerExtractor) ExtractToken(req *http.Request) (string, error) {
9090
tokenHeader := req.Header.Get("Authorization")
9191
// The usual convention is for "Bearer" to be title-cased. However, there's no
9292
// strict rule around this, and it's best to follow the robustness principle here.
93-
if tokenHeader == "" || !strings.HasPrefix(strings.ToLower(tokenHeader), "bearer ") {
93+
if len(tokenHeader) < 7 || !strings.HasPrefix(strings.ToLower(tokenHeader[:7]), "bearer ") {
9494
return "", ErrNoTokenInRequest
9595
}
9696
return tokenHeader[7:], nil

0 commit comments

Comments
 (0)