Skip to content

migrate mysql failure should have started in transaction without the need for dirty #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
u007 opened this issue Oct 6, 2020 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@u007
Copy link

u007 commented Oct 6, 2020

Describe the Bug

when running migration, if any part fail, it should not need to trigger dirty =1
and it should rollback for mysql

Steps to Reproduce
Steps to reproduce the behavior:

  1. add migration with missing field to drop
  2. migrate should fail
  3. schema migration now has latest failed migration number and dirty=1

Expected Behavior
migration should not up the migration number and dirty donot need to be set

Migrate Version
4.11.0
Loaded Source Drivers
e.g. s3, github, go-bindata, gcs, file
Obtained by running: migrate -help

Loaded Database Drivers
Source drivers: s3, github, github-ee, gitlab, go-bindata, godoc-vfs, gcs, file
Database drivers: cassandra, cockroachdb, crdb-postgres, firebirdsql, postgresql, clickhouse, firebird, postgres, mongodb, mysql, redshift, spanner, cockroach, sqlserver, stub

Go Version
none

@dhui dhui added the duplicate This issue or pull request already exists label Oct 6, 2020
@dhui
Copy link
Member

dhui commented Oct 6, 2020

Duplicate of #196

@dhui dhui marked this as a duplicate of #196 Oct 6, 2020
@dhui dhui closed this as completed Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants