Skip to content

Commit 5289972

Browse files
dmitshurgopherbot
authored andcommitted
cmd/rundockerbuildlet: remove Scaleway-specific configuration
Scaleway builders are no longer in use, and most of their code was removed in CL 325694 and CL 325695. This CL removes some more from the rundockerbuildlet command. Updates golang/go#45066. Change-Id: I4b1902ffb8b20ca05f7d76dd041d889decc6f0b1 Reviewed-on: https://go-review.googlesource.com/c/build/+/408939 TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]>
1 parent 0152d3c commit 5289972

File tree

1 file changed

+5
-93
lines changed

1 file changed

+5
-93
lines changed

cmd/rundockerbuildlet/rundockerbuildlet.go

Lines changed: 5 additions & 93 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,14 @@ import (
1616
"fmt"
1717
"io/ioutil"
1818
"log"
19-
"net/http"
2019
"os"
2120
"os/exec"
2221
"path/filepath"
23-
"runtime"
2422
"strings"
2523
"time"
2624

2725
"github.com/aws/aws-sdk-go/aws/ec2metadata"
2826
"github.com/aws/aws-sdk-go/aws/session"
29-
"golang.org/x/build/buildenv"
3027
"golang.org/x/build/internal/cloud"
3128
)
3229

@@ -42,10 +39,9 @@ var (
4239
)
4340

4441
var (
45-
buildKey []byte
46-
scalewayMeta = new(scalewayMetadata)
47-
isReverse = true
48-
isSingleRun = false
42+
buildKey []byte
43+
isReverse = true
44+
isSingleRun = false
4945
// ec2UD contains a copy of the EC2 vm user data retrieved from the metadata.
5046
ec2UD *cloud.EC2UserData
5147
// ec2MetaClient is an EC2 metadata client.
@@ -55,14 +51,7 @@ var (
5551
func main() {
5652
flag.Parse()
5753

58-
if onScaleway() {
59-
*memory = ""
60-
*image = "eu.gcr.io/symbolic-datum-552/scaleway-builder"
61-
*pull = true
62-
*numInst = 1
63-
*basename = "scaleway"
64-
initScalewayMeta()
65-
} else if onEC2() {
54+
if onEC2() {
6655
initEC2Meta()
6756
*memory = ""
6857
*image = ec2UD.BuildletImageURL
@@ -115,29 +104,9 @@ func onEC2() bool {
115104
return ec2MdClient().AvailableWithContext(ctx)
116105
}
117106

118-
func onScaleway() bool {
119-
if *builderEnv == "host-linux-arm-scaleway" {
120-
return true
121-
}
122-
if runtime.GOOS == "linux" && runtime.GOARCH == "arm" {
123-
if _, err := os.Stat("/usr/local/bin/oc-metadata"); err == nil {
124-
return true
125-
}
126-
}
127-
return false
128-
}
129-
130107
func getBuildKey() []byte {
131108
key, err := ioutil.ReadFile(*keyFile)
132109
if err != nil {
133-
if onScaleway() {
134-
const prefix = "buildkey_host-linux-arm-scaleway_"
135-
for _, tag := range scalewayMeta.Tags {
136-
if strings.HasPrefix(tag, prefix) {
137-
return []byte(strings.TrimPrefix(tag, prefix))
138-
}
139-
}
140-
}
141110
log.Fatalf("error reading build key from --key=%s: %v", *keyFile, err)
142111
}
143112
return bytes.TrimSpace(key)
@@ -162,10 +131,6 @@ func checkFix() error {
162131
}
163132
container, name, status := f[0], f[1], f[2]
164133
prefix := *basename
165-
if scalewayMeta != nil {
166-
// scaleway containers are named after their instance.
167-
prefix = scalewayMeta.Hostname
168-
}
169134
if !strings.HasPrefix(name, prefix) {
170135
continue
171136
}
@@ -177,12 +142,7 @@ func checkFix() error {
177142

178143
for num := 1; num <= *numInst; num++ {
179144
var name string
180-
if scalewayMeta != nil && scalewayMeta.Hostname != "" {
181-
// The -name passed to 'docker run' should match the
182-
// c1 instance hostname for debugability.
183-
// There should only be one running container per c1 instance.
184-
name = scalewayMeta.Hostname
185-
} else if onEC2() {
145+
if onEC2() {
186146
name = ec2UD.BuildletName
187147
} else {
188148
name = fmt.Sprintf("%s%02d", *basename, num)
@@ -250,9 +210,6 @@ func checkFix() error {
250210
if *builderEnv != "" {
251211
cmd.Args = append(cmd.Args, "-e", "GO_BUILDER_ENV="+*builderEnv)
252212
}
253-
if u := buildletBinaryURL(); u != "" {
254-
cmd.Args = append(cmd.Args, "-e", "META_BUILDLET_BINARY_URL="+u)
255-
}
256213
cmd.Args = append(cmd.Args,
257214
"-e", "GO_BUILD_KEY_PATH=/buildkey/gobuildkey",
258215
"-e", "GO_BUILD_KEY_DELETE_AFTER_READ=true",
@@ -268,24 +225,6 @@ func checkFix() error {
268225
return nil
269226
}
270227

271-
type scalewayMetadata struct {
272-
Name string `json:"name"`
273-
Hostname string `json:"hostname"`
274-
Tags []string `json:"tags"`
275-
}
276-
277-
func (m *scalewayMetadata) HasTag(t string) bool {
278-
if m == nil {
279-
return false
280-
}
281-
for _, v := range m.Tags {
282-
if v == t {
283-
return true
284-
}
285-
}
286-
return false
287-
}
288-
289228
func initEC2Meta() {
290229
if !onEC2() {
291230
log.Fatal("attempt to initialize metadata on non-EC2 instance")
@@ -309,37 +248,10 @@ func initEC2Meta() {
309248
}
310249
}
311250

312-
func initScalewayMeta() {
313-
const metaURL = "http://169.254.42.42/conf?format=json"
314-
res, err := http.Get(metaURL)
315-
if err != nil {
316-
log.Fatalf("failed to get scaleway metadata: %v", err)
317-
}
318-
defer res.Body.Close()
319-
if res.StatusCode != http.StatusOK {
320-
log.Fatalf("failed to get scaleway metadata from %s: %v", metaURL, res.Status)
321-
}
322-
if err := json.NewDecoder(res.Body).Decode(scalewayMeta); err != nil {
323-
log.Fatalf("invalid JSON from scaleway metadata URL %s: %v", metaURL, err)
324-
}
325-
}
326-
327251
func removeContainer(container string) {
328252
if out, err := exec.Command("docker", "rm", "-f", container).CombinedOutput(); err != nil {
329253
log.Printf("error running docker rm -f %s: %v, %s", container, err, out)
330254
return
331255
}
332256
log.Printf("Removed container %s", container)
333257
}
334-
335-
func buildletBinaryURL() string {
336-
if !onScaleway() {
337-
// Only used for Scaleway currently.
338-
return ""
339-
}
340-
env := buildenv.Production
341-
if scalewayMeta.HasTag("staging") {
342-
env = buildenv.Staging
343-
}
344-
return fmt.Sprintf("https://storage.googleapis.com/%s/buildlet.linux-arm", env.BuildletBucket)
345-
}

0 commit comments

Comments
 (0)