internal/task: remove arbitrary timeout for TestTagTelemetry

findleyr · gopherbot · commit 69e47f484048 · 2023-09-27T16:15:11.000Z
Fixes golang/go#63258 Change-Id: I7b164a7f75b2187a9d7a969b4bee8b4f2d8b87f8 Reviewed-on: https://go-review.googlesource.com/c/build/+/530980 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Heschi Kreinick <heschi@google.com> Auto-Submit: Robert Findley <rfindley@google.com>
diff --git a/internal/task/tagtelemetry_test.go b/internal/task/tagtelemetry_test.go
@@ -8,7 +8,6 @@ import (
 	"context"
 	"fmt"
 	"testing"
-	"time"
 
 	"golang.org/x/build/internal/workflow"
 )
@@ -96,7 +95,7 @@ echo -n %q > config/config.json
 				t.Fatal(err)
 			}
 
-			ctx, cancel := context.WithTimeout(context.Background(), time.Minute)
+			ctx, cancel := context.WithCancel(context.Background())
 			defer cancel()
 
 			outputs, err := w.Run(ctx, &verboseListener{t: t})

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@ import (`
`8`	`8`	`"context"`
`9`	`9`	`"fmt"`
`10`	`10`	`"testing"`
`11`		`- "time"`
`12`	`11`
`13`	`12`	`"golang.org/x/build/internal/workflow"`
`14`	`13`	`)`
`@@ -96,7 +95,7 @@ echo -n %q > config/config.json`
`96`	`95`	`t.Fatal(err)`
`97`	`96`	`}`
`98`	`97`
`99`		`- ctx, cancel := context.WithTimeout(context.Background(), time.Minute)`
	`98`	`+ ctx, cancel := context.WithCancel(context.Background())`
`100`	`99`	`defer cancel()`
`101`	`100`
`102`	`101`	`outputs, err := w.Run(ctx, &verboseListener{t: t})`