Skip to content

Commit a182ba7

Browse files
committed
dashboard: give openbsd/386 more time, and skip pprof vendor tests on arm5
Updates golang/go#19547 Updates golang/go#22594 Change-Id: I0200eebf39c1fada6c6ce146afacb9d140142c5b Reviewed-on: https://go-review.googlesource.com/84035 Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent 0cb6fe3 commit a182ba7

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

dashboard/builders.go

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1082,6 +1082,13 @@ func init() {
10821082
"GOARM=5",
10831083
"GO_TEST_TIMEOUT_SCALE=4", // arm is normally 2; double that.
10841084
},
1085+
ShouldRunDistTest: func(distTest string, isTry bool) bool {
1086+
if strings.Contains(distTest, "vendor/github.com/google/pprof") {
1087+
// Not worth it. And broken.
1088+
return false
1089+
}
1090+
return true
1091+
},
10851092
})
10861093
addBuilder(BuildConfig{
10871094
Name: "nacl-386",
@@ -1113,12 +1120,26 @@ func init() {
11131120
HostType: "host-openbsd-386-60",
11141121
ShouldRunDistTest: noTestDir,
11151122
MaxAtOnce: 1,
1123+
env: []string{
1124+
// cmd/go takes ~192 seconds on openbsd-386
1125+
// now, which is over the 180 second default
1126+
// dist test timeout. So, bump this builder
1127+
// up:
1128+
"GO_TEST_TIMEOUT_SCALE=2",
1129+
},
11161130
})
11171131
addBuilder(BuildConfig{
11181132
Name: "openbsd-386-62",
11191133
HostType: "host-openbsd-386-62",
11201134
ShouldRunDistTest: noTestDir,
11211135
MaxAtOnce: 1,
1136+
env: []string{
1137+
// cmd/go takes ~192 seconds on openbsd-386
1138+
// now, which is over the 180 second default
1139+
// dist test timeout. So, bump this builder
1140+
// up:
1141+
"GO_TEST_TIMEOUT_SCALE=2",
1142+
},
11221143
})
11231144
addBuilder(BuildConfig{
11241145
Name: "openbsd-amd64-62",

0 commit comments

Comments
 (0)