Skip to content

Commit add2602

Browse files
mknyszekgopherbot
authored andcommitted
cmd/gomote: add support for groups to create
For golang/go#53956. Change-Id: Icaf1e9dc845812d7989f14802a2f950da2d365ff Reviewed-on: https://go-review.googlesource.com/c/build/+/418274 Auto-Submit: Michael Knyszek <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Michael Knyszek <[email protected]>
1 parent ca79eba commit add2602

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

cmd/gomote/create.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,6 @@ func legacyCreate(args []string) error {
137137
}
138138

139139
func create(args []string) error {
140-
if activeGroup != nil {
141-
return fmt.Errorf("command does not yet support groups")
142-
}
143-
144140
fs := flag.NewFlagSet("create", flag.ContinueOnError)
145141

146142
fs.Usage = func() {
@@ -177,12 +173,12 @@ func create(args []string) error {
177173
return fmt.Errorf("failed to create buildlet: %v", statusFromError(err))
178174
}
179175
var instanceName string
176+
updateLoop:
180177
for {
181178
update, err := stream.Recv()
182179
switch {
183180
case err == io.EOF:
184-
fmt.Println(instanceName)
185-
return nil
181+
break updateLoop
186182
case err != nil:
187183
return fmt.Errorf("failed to create buildlet: %v", statusFromError(err))
188184
case update.GetStatus() != protos.CreateInstanceResponse_COMPLETE && status:
@@ -191,4 +187,10 @@ func create(args []string) error {
191187
instanceName = update.GetInstance().GetGomoteId()
192188
}
193189
}
190+
fmt.Println(instanceName)
191+
if activeGroup == nil {
192+
return nil
193+
}
194+
activeGroup.Instances = append(activeGroup.Instances, instanceName)
195+
return storeGroup(activeGroup)
194196
}

0 commit comments

Comments
 (0)