Skip to content

Commit e2b9141

Browse files
committed
app, gitmirror, maintner: use maintner for dashboard, not datastore
Historically, the build.golang.org was the entire build system, and it maintained a parallel copy of that git history in its datastore. It was always buggy and incomplete and things like force pushes were scary because the datastore mirror could get out of sync. It was also a lot of code to support that sync. This changes build.golang.org to instead get the git history from maintnerd, and then we can remove all the HTTP handlers around updating it, and can remove all the gitmirror code to call it to maintain it. Now build.golang.org only keeps build results, keyed on the commit hash. It's much less code, but is still an App Engine app for now. (but it's getting small enough, that porting it to cloud.google.com/go/datastore is looking very simple) This also adds a new "repos" package to unify the configuration of the various Go repos. There were incomplete & redundant copies all over the place. Updates golang/go#34744 Fixes golang/go#35828 Fixes golang/go#31236 (New branch=mixed support adds this when desired) Fixes golang/go#35944 Change-Id: Ifb39417287df3dea052ba8510566d80b4bc75d51 Reviewed-on: https://go-review.googlesource.com/c/build/+/208697 Reviewed-by: Bryan C. Mills <[email protected]>
1 parent 96d53bb commit e2b9141

File tree

22 files changed

+2154
-1877
lines changed

22 files changed

+2154
-1877
lines changed

app/appengine/Makefile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@ usage:
22
echo "See Makefile for usage"
33
exit 1
44

5-
deploy:
5+
deploy-prod:
66
go install golang.org/x/build/cmd/xb
77
GO111MODULE=on gcloud app --account=$$(xb google-email) --project=golang-org deploy app.yaml
8+
9+
deploy-test:
10+
go install golang.org/x/build/cmd/xb
11+
GO111MODULE=on gcloud app --account=$$(xb google-email) --project=golang-org deploy --no-promote app.yaml

app/appengine/app.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ runtime: go111
22
service: build
33

44
handlers:
5-
- url: /static
6-
static_dir: app/appengine/static
7-
secure: always
85
- url: /.*
96
script: auto
107
secure: always

0 commit comments

Comments
 (0)