Skip to content

Commit f2d94d7

Browse files
millerresearchgopherbot
authored andcommitted
cmd/coordinator: exempt plan9-arm from repeatedCommunicationError
The coordinator has a special case for Plan 9 builders to treat communication errors (when the builder stops responding) as permanent instead of retrying the build. This isn't appropriate for the plan9-arm builder (which is not on a virtual machine and can suffer temporary network disconnects or unexpected reboots). Exempting plan9-arm from this check will prevent spurious build failures which need a manual retry. Fixes golang/go#52677 Change-Id: I7059eec115f680b3f6cd98368c1c566b7310f86f Reviewed-on: https://go-review.googlesource.com/c/build/+/470355 Reviewed-by: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]>
1 parent f78cb9a commit f2d94d7

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

cmd/coordinator/buildstatus.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2000,8 +2000,9 @@ func (st *buildStatus) repeatedCommunicationError(execErr error) error {
20002000
if execErr == nil {
20012001
return nil
20022002
}
2003-
// For now, only do this for plan9, which is flaky (Issue 31261)
2004-
if strings.HasPrefix(st.Name, "plan9-") && execErr == errBuildletsGone {
2003+
// For now, only do this for plan9, which is flaky (Issue 31261),
2004+
// but not for plan9-arm (Issue 52677)
2005+
if strings.HasPrefix(st.Name, "plan9-") && st.Name != "plan9-arm" && execErr == errBuildletsGone {
20052006
// TODO: give it two tries at least later (store state
20062007
// somewhere; global map?). But for now we're going to
20072008
// only give it one try.

0 commit comments

Comments
 (0)