Skip to content

Commit 17d98cb

Browse files
dmitshurgopherbot
authored andcommitted
cmd/viewcore: don't try to build for GOARCH=wasm
It doesn't build for GOOS=js GOARCH=wasm the same reason it doesn't build for aix and plan9: the readline dependency doesn't support it. For golang/go#61104. Change-Id: Ic7f45fda06c2b01555048e2e167ae0e188b2b492 Cq-Include-Trybots: luci.golang.try:x_debug-gotip-js-wasm Reviewed-on: https://go-review.googlesource.com/c/debug/+/533696 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Michael Pratt <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]>
1 parent b12aaab commit 17d98cb

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

cmd/viewcore/html.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
// Use of this source code is governed by a BSD-style
33
// license that can be found in the LICENSE file.
44

5-
//go:build !aix && !plan9
6-
// +build !aix,!plan9
5+
//go:build !aix && !plan9 && !wasm
6+
// +build !aix,!plan9,!wasm
77

8-
// (https://golang.org/issue/32839)
8+
// (go.dev/issue/32839)
99

1010
package main
1111

cmd/viewcore/main.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
// Use of this source code is governed by a BSD-style
33
// license that can be found in the LICENSE file.
44

5-
// Skip aix and plan9 for now: github.com/chzyer/readline doesn't support them.
6-
// (https://golang.org/issue/32839)
5+
// Skip some ports that github.com/chzyer/readline doesn't support.
6+
// (See go.dev/issue/32839.)
77
//
8-
//go:build !aix && !plan9
9-
// +build !aix,!plan9
8+
//go:build !aix && !plan9 && !wasm
9+
// +build !aix,!plan9,!wasm
1010

1111
// The viewcore tool is a command-line tool for exploring the state of a Go process
1212
// that has dumped core.

0 commit comments

Comments
 (0)