status: return error from collectConstraints()

Author: darkowlzz

cmd/dep/status.go

@@ -417,7 +417,10 @@ func runStatusAll(ctx *dep.Ctx, out outputter, p *dep.Project, sm gps.SourceMana
 		return false, 0, errors.Wrapf(err, "could not set up solver for input hashing")
 	}
 
-	cm := collectConstraints(ctx, p, sm)
+	cm, err := collectConstraints(ctx, p, sm)
+	if err != nil {
+		return false, 0, err
+	}
 
 	// Get the project list and sort it so that the printed output users see is
 	// deterministically ordered. (This may be superfluous if the lock is always
@@ -684,7 +687,7 @@ type projectConstraint struct {
 type constraintsCollection map[string][]projectConstraint
 
 // collectConstraints collects constraints declared by all the dependencies.
-func collectConstraints(ctx *dep.Ctx, p *dep.Project, sm gps.SourceManager) constraintsCollection {
+func collectConstraints(ctx *dep.Ctx, p *dep.Project, sm gps.SourceManager) (constraintsCollection, error) {
 	logger := ctx.Err
 	if !ctx.Verbose {
 		logger = log.New(ioutil.Discard, "", 0)
@@ -695,7 +698,7 @@ func collectConstraints(ctx *dep.Ctx, p *dep.Project, sm gps.SourceManager) cons
 	// Get direct deps of the root project.
 	_, directDeps, err := getDirectDependencies(sm, p)
 	if err != nil {
-		logger.Println("Error getting direct deps:", err)
+		return nil, err
 	}
 
 	// Create a root analyzer.
@@ -751,12 +754,13 @@ func collectConstraints(ctx *dep.Ctx, p *dep.Project, sm gps.SourceManager) cons
 	close(errCh)
 
 	if len(errCh) > 0 {
-		for err := range errCh {
-			logger.Println(err.Error())
+		err = errors.New("failed to collect constraints")
+		for e := range errCh {
+			logger.Println(e.Error())
 		}
 	}
 
-	return constraintCollection
+	return constraintCollection, err
 }
 
 type byProject []projectConstraint

cmd/dep/status_test.go

@@ -398,7 +398,7 @@ func TestCollectConstraints(t *testing.T) {
 
 	for _, c := range cases {
 		t.Run(c.name, func(t *testing.T) {
-			gotConstraints := collectConstraints(ctx, &c.project, sm)
+			gotConstraints, _ := collectConstraints(ctx, &c.project, sm)
 
 			if !reflect.DeepEqual(gotConstraints, c.wantConstraints) {
 				t.Fatalf("Unexpected collected constraints: \n\t(GOT): %v\n\t(WNT): %v", gotConstraints, c.wantConstraints)