Do not error out when the current directory is a symlink

[mildred]

Here, we generate an error that is not necessary :

dep/context.go

Line 215 in 5f1783b

return "", errors.Errorf("'%s' is linked to another path within a GOPATH (%s)", path, gp)

There are cases where a repository cannot be cloned in the correct location inside the GOPATH as described in golang/go#20535. In such cases, a solution is to generate a mock gopath with a symlink at the correct gopath location to the repository checkout directory. We arrive at a perfectly valid setup where the current directory, although a symlink, is inside the GOPATH. There is no reason to error out in such cases.

This is probably the same thing as #683

[sdboyer]

hi! welcome, thanks for posting the issues 😄

There is no reason to error out in such cases.

The error you're identifying is for the specific situation where there's a symlink from one GOPATH, into another GOPATH. It doesn't seem like that's your actual issue, though (I'm not entirely clear from either this issue or the golang/go one you posted); if all you want to do is symlink into a GOPATH, then that is something we aim to support, but we regressed and lost that capability somewhere along the way. #641 should fix it.

If your goal is GOPATH-to-GOPATH symlinking, though, then that's not something we plan to support. It adds complexity and ambiguity, and would serve very little purpose outside of one-time hinting to dep init - a very narrow use case.

[ibrasho]

Closing this since #641 is merged now.