You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 9, 2020. It is now read-only.
DeduceConstraint currently uses a simple check to determine if a string is a revision. But we can do better!
By moving this into *sourceMgr, we create an opportunity to do better validation here. Rather than deducing whether it's a revision from what general rules we have about the patterns of the bytes, we can actually hand this off to a sourceGateway, which can validate that it's an appropriate revision for that source type.
This is for after #761 is merged, which moves DeduceConstraint from the ensure command into SourceManager. Also note that #715 also touches the function, so waiting for that to settle down would be best.
The text was updated successfully, but these errors were encountered:
DeduceConstraint
currently uses a simple check to determine if a string is a revision. But we can do better!https://github.com/golang/dep/pull/761/files#r122593455
This is for after #761 is merged, which moves
DeduceConstraint
from the ensure command intoSourceManager
. Also note that #715 also touches the function, so waiting for that to settle down would be best.The text was updated successfully, but these errors were encountered: