Skip to content

Commit 059ada5

Browse files
committed
cmd/dist: skip broken cgo race tests on darwin
CL 26668 exposed #17065. Skip the cgo race tests on darwin for now. Updates #17065 Change-Id: I0ad0ce2ff1af6d515b8ce6184ddeabc49806950f Reviewed-on: https://go-review.googlesource.com/29077 Run-TryBot: Josh Bleecher Snyder <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent 2e67514 commit 059ada5

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/cmd/dist/test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1016,7 +1016,8 @@ func (t *tester) raceTest(dt *distTest) error {
10161016
// The race builder should catch any error here, but doesn't.
10171017
// TODO(iant): Figure out how to catch this.
10181018
// t.addCmd(dt, "src", "go", "test", "-race", "-run=TestParallelTest", "cmd/go")
1019-
if t.cgoEnabled {
1019+
// TODO: Remove t.goos != "darwin" when issue 17065 is fixed.
1020+
if t.cgoEnabled && t.goos != "darwin" {
10201021
env := mergeEnvLists([]string{"GOTRACEBACK=2"}, os.Environ())
10211022
cmd := t.addCmd(dt, "misc/cgo/test", "go", "test", "-race", "-short", t.runFlag(""))
10221023
cmd.Env = env

0 commit comments

Comments
 (0)