Skip to content

Commit 1aa191b

Browse files
committed
doc: remove some TODOs from go1.8.html
TBR=See https://golang.org/cl/33244 Updates #17929 Change-Id: I5d92bd62b6560d245f77fa042c7e35d9eddc4994 Reviewed-on: https://go-review.googlesource.com/33683 Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent 406d2fa commit 1aa191b

File tree

1 file changed

+32
-34
lines changed

1 file changed

+32
-34
lines changed

doc/go1.8.html

+32-34
Original file line numberDiff line numberDiff line change
@@ -237,19 +237,17 @@ <h3 id="tool_trace">Trace</h3>
237237

238238
<h3 id="tool_vet">Vet</h3>
239239

240-
<p>TODO:</p>
241-
<pre>
242-
cmd/vet: accept space-separated tag lists for compatibility with cmd/go (CL 32030)
243-
cmd/vet: allow ^& uintptr arithmetic (CL 27156)
244-
cmd/vet: allow any printf verb with any interface (CL 27127)
245-
cmd/vet: check for copying of array of locks (CL 24340)
246-
cmd/vet: check for duplicate json, xml struct field tags (CL 16704)
247-
cmd/vet: detect defer resp.Body.Close() before error check (CL 32911)
248-
cmd/vet: diagnose non-space-separated struct tag like `json:"x",xml:"y"` (CL 32031)
249-
cmd/vet: improve asmdecl parameter handling (CL 27150)
250-
cmd/vet: properly handle indexed arguments in printf (CL 24391)
251-
cmd/vet: skip printf check for non-constant format string during failed import (CL 29014)
252-
</pre>
240+
<p>Vet is stricter in some ways and looser others which
241+
caused false positives.</p>
242+
243+
<p>Vet now checks copying of array of locks,
244+
duplicate JSON and XML struct field tags,
245+
non-space-separated struct tags,
246+
deferred calls to HTTP <code>Response.Body.Close</code>
247+
before checking errors,
248+
indexed arguments in <code>Printf</code>,
249+
and improves existing checks.</p>
250+
</p>
253251

254252
<h3 id="compiler">Compiler Toolchain</h3>
255253

@@ -660,7 +658,7 @@ <h3 id="minor_library_changes">Minor changes to the library</h3>
660658

661659
<p>
662660
<!-- CL 30790 -->
663-
The new <a href="/pkg/crypto/tls/#Config.GetConfigForClient"><code>Config.GetConfigForClient</code></a> (TODO: make link work)
661+
The new <a href="/pkg/crypto/tls/#Config.GetConfigForClient"><code>Config.GetConfigForClient</code></a>
664662
callback allows selecting a configuration for a client dynamically, based
665663
on the client's
666664
<a href="/pkg/crypto/tls/#ClientHelloInfo"><code>ClientHelloInfo</code></a>.
@@ -675,7 +673,7 @@ <h3 id="minor_library_changes">Minor changes to the library</h3>
675673
</p>
676674

677675
<p> <!-- CL 32115 -->
678-
The new <a href="/pkg/crypto/tls/#Config.GetClientCertificate"><code>Config.GetClientCertificate</code></a> (TODO: make link work)
676+
The new <a href="/pkg/crypto/tls/#Config.GetClientCertificate"><code>Config.GetClientCertificate</code></a>
679677
callback allows selecting a client certificate based on the server's
680678
TLS <code>CertificateRequest</code> message, represented by the new
681679
<a href="/pkg/crypto/tls/#CertificateRequestInfo"><code>CertificateRequestInfo</code></a>.
@@ -684,15 +682,14 @@ <h3 id="minor_library_changes">Minor changes to the library</h3>
684682
<p> <!-- CL 27434 -->
685683
The new
686684
<a href="/pkg/crypto/tls/#Config.KeyLogWriter"><code>Config.KeyLogWriter</code></a>
687-
(TODO: make link work) allows debugging TLS connections
685+
allows debugging TLS connections
688686
in <a href="https://www.wireshark.org/">WireShark</a> and
689687
similar tools.
690688
</p>
691689

692690
<p> <!-- CL 32115 -->
693691
The new
694692
<a href="/pkg/crypto/tls/#Config.VerifyPeerCertificate"><code>Config.VerifyPeerCertificate</code></a>
695-
(TODO: make link work)
696693
callback allows additional validation of a peer's presented certificate.
697694
</p>
698695

@@ -825,17 +822,18 @@ <h3 id="minor_library_changes">Minor changes to the library</h3>
825822
<dl id="debug_pe"><dt><a href="/pkg/debug/pe/">debug/pe</a></dt>
826823
<dd>
827824
<p> <!-- CL 22720, CL 27212, CL 22181, CL 22332, CL 22336, Issue 15345 -->
828-
TODO: describe Issue 15345 and CL 22181, CL 22332, CL 22336
829-
<pre>pkg debug/pe, method (*COFFSymbol) FullName(StringTable) (string, error)
830-
pkg debug/pe, method (StringTable) String(uint32) (string, error)
831-
pkg debug/pe, type File struct, COFFSymbols []COFFSymbol
832-
pkg debug/pe, type File struct, StringTable StringTable
833-
pkg debug/pe, type Reloc struct
834-
pkg debug/pe, type Reloc struct, SymbolTableIndex uint32
835-
pkg debug/pe, type Reloc struct, Type uint16
836-
pkg debug/pe, type Reloc struct, VirtualAddress uint32
837-
pkg debug/pe, type Section struct, Relocs []Reloc
838-
pkg debug/pe, type StringTable []uint8</pre>
825+
The package has been fleshed out and is now used by <a href="/cmd/link/">the Go linker</a>.
826+
New are
827+
<a href="/pkg/debug/pe/#Reloc"><code>Reloc</code></a>,
828+
<a href="/pkg/debug/pe/#Section"><code>Section</code></a>,
829+
<a href="/pkg/debug/pe/#StringTable"><code>StringTable</code></a>,
830+
the method
831+
<a href="/pkg/debug/pe/#COFFSymbol.FullName"><code>COFFSymbol.FullName</code></a>,
832+
and
833+
<a href="/pkg/debug/pe/#File"><code>File</code></a>
834+
fields
835+
<a href="/pkg/debug/pe/#File.COFFSymbols"><code>COFFSymbols</code></a> and
836+
<a href="/pkg/debug/pe/#File.StringTable"><code>StringTable</code></a>.
839837
</p>
840838
</dd>
841839
</dl>
@@ -1050,7 +1048,9 @@ <h3 id="minor_library_changes">Minor changes to the library</h3>
10501048
depend on implementations obeying the documentation.
10511049
</p>
10521050
<p><i>Updating:</i> implementations of the <code>Conn</code> interface should verify
1053-
they implement the documented semantics. TODO: https://golang.org/cl/18097
1051+
they implement the documented semantics. The
1052+
<a href="https://godoc.org/golang.org/x/net/nettest">golang.org/x/net/nettest</a>
1053+
package will exercise a <code>Conn</code> and validate it behaves properly.
10541054
</p>
10551055

10561056
<p><!-- CL 32099 -->
@@ -1164,11 +1164,9 @@ <h3 id="minor_library_changes">Minor changes to the library</h3>
11641164
<ul>
11651165
<li><!-- CL 28930 -->
11661166
The <a href="/pkg/net/http/#Client"><code>Client</code></a>
1167-
now copies most request headers on redirect. Authentication-specific
1168-
headers are only sent to the same origin or subdomains thereof.
1169-
Cookies are not sent again, unless they were set explicitly.
1170-
TODO: verify this, and link to docs once https://golang.org/issue/18096
1171-
is fixed.
1167+
now copies most request headers on redirect. See
1168+
<a href="/pkg/net/http/#Client">the documentation</a>
1169+
on the <code>Client</code> type for details.
11721170
</li>
11731171

11741172
<li><!-- CL 29072 -->

0 commit comments

Comments
 (0)