Skip to content

Commit 30674ae

Browse files
committed
cmd/dist: disable misc/cgo/testsanitizers on ppc64le
A while back in this release the sanitizer tests were enabled for ppc64le, where previously they were never run. This uncovered some errors in these tests on ppc64le. One linker fix was made but there are still bugs in how tsan is made to work within the code, especially in how signals are enabled with cgo. Some attempts were made to make this work but intermittent failures continue to happen with the Trybots so I am just going to disable this test for ppc64le within cmd/dist. Updates #45040 Change-Id: I5392368ccecd4079ef568d0c645c9f7c94016d99 Reviewed-on: https://go-review.googlesource.com/c/go/+/315430 Run-TryBot: Lynn Boger <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Trust: Cherry Zhang <[email protected]>
1 parent 2c9f5a1 commit 30674ae

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/cmd/dist/test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -749,8 +749,9 @@ func (t *tester) registerTests() {
749749
if gohostos == "linux" && goarch == "amd64" {
750750
t.registerTest("testasan", "../misc/cgo/testasan", "go", "run", ".")
751751
}
752-
if goos == "linux" {
752+
if goos == "linux" && goarch != "ppc64le" {
753753
// because syscall.SysProcAttri struct used in misc/cgo/testsanitizers is only built on linux.
754+
// Some inconsistent failures happen on ppc64le so disable for now.
754755
t.registerHostTest("testsanitizers", "../misc/cgo/testsanitizers", "misc/cgo/testsanitizers", ".")
755756
}
756757
if t.hasBash() && goos != "android" && !t.iOS() && gohostos != "windows" {

0 commit comments

Comments
 (0)