Skip to content

Commit 3e1478e

Browse files
cuonglmgopherbot
authored andcommitted
cmd/compile: cleanup atomic.Pointer[T] inline test
Updates #57410 Change-Id: I9be38e20c6b83d14f7785049a66de77ac7ecdf15 Reviewed-on: https://go-review.googlesource.com/c/go/+/463997 Run-TryBot: Cuong Manh Le <[email protected]> Reviewed-by: Keith Randall <[email protected]> Auto-Submit: Cuong Manh Le <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Matthew Dempsky <[email protected]>
1 parent f36c7c5 commit 3e1478e

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

src/cmd/compile/internal/test/inl_test.go

+4-9
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,10 @@ func TestIntendedInlining(t *testing.T) {
208208
"(*Uintptr).Load",
209209
"(*Uintptr).Store",
210210
"(*Uintptr).Swap",
211-
// (*Pointer[T])'s methods' handled below.
211+
"(*Pointer[go.shape.int]).CompareAndSwap",
212+
"(*Pointer[go.shape.int]).Load",
213+
"(*Pointer[go.shape.int]).Store",
214+
"(*Pointer[go.shape.int]).Swap",
212215
},
213216
}
214217

@@ -234,14 +237,6 @@ func TestIntendedInlining(t *testing.T) {
234237
// (*Bool).CompareAndSwap is just over budget on 32-bit systems (386, arm).
235238
want["sync/atomic"] = append(want["sync/atomic"], "(*Bool).CompareAndSwap")
236239
}
237-
if true /* was buildcfg.Experiment.Unified */ {
238-
// Non-unified IR does not report "inlining call ..." for atomic.Pointer[T]'s methods.
239-
// TODO(cuonglm): remove once non-unified IR frontend gone.
240-
want["sync/atomic"] = append(want["sync/atomic"], "(*Pointer[go.shape.int]).CompareAndSwap")
241-
want["sync/atomic"] = append(want["sync/atomic"], "(*Pointer[go.shape.int]).Load")
242-
want["sync/atomic"] = append(want["sync/atomic"], "(*Pointer[go.shape.int]).Store")
243-
want["sync/atomic"] = append(want["sync/atomic"], "(*Pointer[go.shape.int]).Swap")
244-
}
245240

246241
switch runtime.GOARCH {
247242
case "386", "wasm", "arm":

0 commit comments

Comments
 (0)